668635 - Show compatibility error for using nsINavHistoryObserver in Firefox 7

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 633266, all methods in nsINavHistoryObserver that take a URI will also require a GUID parameter. This is pretty much all meaningful methods, so we should just flag any instances of nsINavHistoryObserver.

This should show an error and prevent the add-on from being upgraded.

Message:

Loading javascript: or data: URLs through the URL bar may no longer work as expected in Firefox 6. If you load these types of URL, please test your add-on on the latest Firefox 6 builds, or refer to <LINKED_BUG> for more information.

Krupa:

https://addons.mozilla.org/en-US/firefox/addon/categorize/

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

Wrong message. This should be:

The nsINavHistoryObserver interface has changed in Firefox 7. Most function calls now required a GUID parameter, please refer to <LINKED_SPEC> and <LINKED_BUG> for more information.


Spec link: https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsINavHistoryService

Comment 2

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/amo-validator/commit/572010cfde71f5728c1adebc4aec0c26387193dc

Comment 3

[krupa raj[:krupa]]

verified at 
https://addons.allizom.org/en-US/developers/addon/categorize/validation-result/39882
https://addons.allizom.org/en-US/developers/addon/closen-forget/validation-result/37322
https://addons.allizom.org/en-US/developers/addon/read-it-later/validation-result/37956