66865 - Duplicate code in nsComponentManager

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Bratell]

There seems to be some extra code lines in nsComponentManager.cpp that costs 4 
microseconds at startup (tripped over it while playing with Quantify). :-)

The patch is below:

diff -u -r1.141 nsComponentManager.cpp
--- nsComponentManager.cpp      2001/01/27 22:50:24     1.141
+++ nsComponentManager.cpp      2001/01/28 14:51:36
@@ -816,7 +816,6 @@
     nsCOMPtr<nsIRegistryEnumerator> regEnum = do_QueryInterface(cidEnum, &rv);
     if (NS_FAILED(rv)) return rv;

-    rv = regEnum->First();
     for (rv = regEnum->First();
          NS_SUCCEEDED(rv) && (regEnum->IsDone() != NS_OK);
          rv = regEnum->Next())
@@ -868,7 +867,6 @@
     regEnum = do_QueryInterface(contractidEnum, &rv);
     if (NS_FAILED(rv)) return rv;

-    rv = regEnum->First();
     for (rv = regEnum->First();
          NS_SUCCEEDED(rv) && (regEnum->IsDone() != NS_OK);
          rv = regEnum->Next())


I can check it in if I get a review.

Comment 1

[Peter "jag" Annema]

nsCOMPtr<nsIRegistryEnumerator> regEnum = do_QueryInterface(cidEnum, &rv);

While you're in there you might want to turn that line into:

nsCOMPtr<nsIRegistryEnumerator> regEnum(do_QueryInterface(cidEnum, &rv));

which avoids creating a temp. copy for some compilers.

r=jag on the patch you have here though.

Comment 2

[Scott Collins]

Has this patch been checked in?  If not, I'll get it in as soon as possible.

Comment 3

[Blake Ross]

sr=scc?

Comment 4

[Daniel Bratell]

I was waiting for the sr from jband, but if you take the sr, and want to check 
it in, it's fine with me.

Comment 5

[Scott Collins]

sr=scc, yes.  I'll check it in if no one else with access plans a checkin in the
near future.

Comment 6

[Peter "jag" Annema]

I'll check this in (if blake doesn't beat me to it)

Comment 7

[Peter "jag" Annema]

Or Daniel for that matter :-) Sorry, missed your comment there. Wanna check this
in?

Comment 8

[Daniel Bratell]

Be my guest(s). That way I can go to sleep and won't have to wait for the tree 
to be green.  :-)

But, if haven't done it by the morning... :-)

Comment 9

[Peter "jag" Annema]

Checked in.

Comment 10

[Blake Ross]

(checked in the QI change..)

Reopening, something happened to the resolution.

Comment 11

[Blake Ross]

Fixed.