Assertions in l10n testrun do not contain a message

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
--
major
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Aleksej, Assigned: whimboo)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lib][testday-20110701], URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Mozmill 1.5.3 and 1.5.4b5.

Russian Nightly Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110630 Firefox/7.0a1

The Information column for the testCropped/test1.js failure is a bunch of list bullets without text.
(Reporter)

Comment 1

7 years ago
Same happens with at least /testAccessKeys/test1.js
Severity: normal → major
(Assignee)

Comment 2

7 years ago
Does that only happen for 7.0 builds of Firefox or are 6.0 and 5.0 builds also affected?
(Assignee)

Comment 4

7 years ago
So it should have been caused by a regression in Firefox 6. Would be great if someone could check for a regression range.
Keywords: regression, regressionwindow-wanted
(Reporter)

Comment 5

7 years ago
Firefox 6.0a1 (6.0a1, en-US, 20110413030543)
Firefox 6.0a1 (6.0a1, en-US, 20110414030535)

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6bcaec19d09e&tochange=aa200a803e07
(Assignee)

Comment 6

7 years ago
I assume it's also related to bug 637207 and bug 650646. Will check later what has to be changed to make it work again. Thanks for finding the regression range!
(Assignee)

Updated

7 years ago
Keywords: regressionwindow-wanted

Comment 7

7 years ago
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/15312549
(Assignee)

Comment 8

7 years ago
I will check this today
Assignee: nobody → hskupin
(Assignee)

Comment 9

7 years ago
Created attachment 545895 [details] [diff] [review]
Patch v1

We should simply get rid of the old jumlib assertions and use our new soft assertions (expect). That will solve our problems here.
Attachment #545895 - Flags: review?(gmealer)
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Summary: assertions do not contain descriptions (testrun_l10n.py — testCropped/test1.js) assertions do not contain descriptions (testrun_l10n.py — testCropped/test1.js) → Assertions in l10n testrun do not contain a message Assertions in l10n testrun do not contain a message
Whiteboard: [testday-20110701] → [testday-20110701][shared module]
Comment on attachment 545895 [details] [diff] [review]
Patch v1

r+, looks fine. We finally found a real-life use for pass()/fail()!

I'm not a big fan of having one-sided assertions though--that is, ones where it fails when bad but does nothing when good. It'll give an inconsistent number of test results depending on whether things fail or not.

Would it be worth it to loop back at some point and add elses to each if that do an expect.pass?
Attachment #545895 - Flags: review?(gmealer) → review+
(Assignee)

Updated

7 years ago
Whiteboard: [testday-20110701][shared module] → [mozmill-l
(Assignee)

Comment 11

7 years ago
I would punt this for now, but yes we should. I'm happy that those scripts are working for now but we have to investigate more time to get everything updated. It's really something for the future.

Landed on all supported branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/d8d0f9531d31 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/92cea4f5f594 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/fd665a90c424 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/e21319c10521 (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/3330137a61bd (2.0)
http://hg.mozilla.org/qa/mozmill-tests/rev/efb11a741a54 (1.9.2)
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-l → [mozmill-l10n][testday-20110701][shared module]
(Reporter)

Updated

7 years ago
Depends on: 671817
(Assignee)

Updated

7 years ago
Component: Mozmill Tests → Mozmill Shared Modules
(Assignee)

Updated

6 years ago
Component: Mozmill Shared Modules → Mozmill Tests
(Assignee)

Updated

6 years ago
Whiteboard: [mozmill-l10n][testday-20110701][shared module] → [lib]
(Assignee)

Updated

6 years ago
Whiteboard: [lib] → [lib][testday-20110701]
You need to log in before you can comment on or make changes to this bug.