668775 - [csb] Search engine setup for Firefox for Kashubian.

Status: RESOLVED FIXED

(Mozilla Localizations :: csb / Kashubian, defect)

Description

[Axel Hecht [:Pike]]

We want to ship Firefox a good list of search engines for Kashubian. 

We're going to work towards this in three phases. First, the localization team and Milos (Milos Dinic) will look at the market for the language and come up with a good set of search providers. Jurk, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Firefox/Productization>. 

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:
Google, Yahoo!, Bing, Amazon, eBay, Wikipedia

After we decided on a particular search engine, Milos will contact the owner and ask for permission, and for specifics like proper search flags. Jurk, we'll likely need your help to at least get the contact information.

Once we have a specification on what the searchengines for Kashubian should look like, the localization team and Milos will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Milos. After a successful review, the localization team will land them.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Milos, Stas, Axel or someone else appointed by Milos. The data here is sensitive to users and our search partners, thus the extra care here.

The Kashubian team will be driving this bug to completion.

Comment 1

[Jurk]

Taking into consideration the guidance provided on https://wiki.mozilla.org/L10n:Firefox/Productization, the Kashubian Mozilla Localization Team suggest the Polish productization preferences be utilized with the exception of Wikipedia, which is available in Kashubian (csb.wikipedia.pl). Rationale: although some of the Kashubian FF users reside in Canada, a vast majority of them live in Poland. The following search lists seems to be currently used by the Polish FF [Bug 604002]:
     1 google
     2 wp-pl
     3 allegro-pl
     4 csb wikipedia-pl (different from Polish FF)
     5 pwn-pl
     6 merlin-pl
     7 fbc-pl

Comment 2

[Jurk]

I assume this bug is complete.

Comment 3

[Milos Dinic [:Milos]]

For this bug to be resolved/fixed, I'll need you to clone your Firefox mercurial repository, make the needed changes, and finally attach a patch(diff) here and flag me for a review.

As Axel already said, please don't commit any changes before you get a positive review from either Stas, Axel or me.

Should you need any help with mercurial or anything else, feel free to ask here, on IRC(channel #l10n, server irc.mozilla.org) or mail me directly([e-mail]).

Comment 4

[Jurk]

What is the URL to the Firefox mercurial repository I need to clone?

Comment 5

[Jurk]

Milos,

URL had been identified and csb repository cloned. This and other bugs to be released soon. Thanks for your patience.

Comment 6

[Jurk]

Attachment: SearchPlugins for Firefox csb

Milos,

Attached is the kdiff patch including search engines for the Kashubian Firefox. Your review is being requested.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 552983 [details] [diff] [review]
SearchPlugins for Firefox csb

r- on this one:

list.txt.orig shouldn't be in this patch, on the other hand, we'll want a copy of the wp-pl.xml etc to be in browser/searchplugins/ and you want to adapt the wikipedia plugin to point to the csb version of wikipedia.

Comment 8

[Jurk]

Attachment: SearchPlugins for Firefox csb

Milos,

While I have to find a way to connect to Mozilla to push the patched, here is the one needed for this bug. In addition, I will copy the various .xml files, which my Polish brothers have developed :)

Let me know.

Comment 9

[Milos Dinic [:Milos]]

Comment on attachment 554180 [details] [diff] [review]
SearchPlugins for Firefox csb

Review of attachment 554180 [details] [diff] [review]:
-----------------------------------------------------------------

List.txt file looks good, but that's not sufficient. You need to copy over files, then add them to version control(hg add), and then create a patch and flag me for a review.

Comment 10

[Jurk]

Attachment: SearchPlugins for Firefox csb

Milos,
I have created wikipedijô-csb.xml and copied the Polish ones, + google (default). Then, I issued hg add. Next, I created the attached patch, including these changes.

Comment 11

[Jurk]

Attachment: earch Plugins (csb)

Milos,

I ended up recreating the patch, so here it is.

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 554649 [details] [diff] [review]
earch Plugins (csb)

Hah, jumping on Milos' review requests again, harharhar, pirate review day. There's even thunder going with it.

r- for three things:

The wikipedia plugin itself is apparently not in utf-8, but in some other charset. 

The entry in list.txt should be the filename of the wikipedia plugin, without the .xml, so just wikipedia-csb.

Also, you don't need to add the google.xml plugin, that's going to be picked up from the en-US source directory anyway.

Comment 13

[Jurk]

Attachment: Kashubian search plugins

Axel, Milos,

A learning process for me. Here's what I've done:

1. Converted Wikipedia.xml to UTF-8 charset.
2. Corrected the name of Wikipedia inside the list.txt file -- BTW, mercurial didn't like the "ô" in the file name(as in Wikipedjô); so I used "Wikipedia" instead.
3. Removed google.xml plugin (already in the 'default' repository).

Hope I got it this time.

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 554709 [details] [diff] [review]
Kashubian search plugins

Looks good to me.

Please fix the check-in message to say something like

bug 668775, search engines for csb, mostly what pl uses, r=[e-mail]

Differences: right bug number, no [:mq], refer to pl, name the reviewer.

Comment 15

[Jurk]

The patch was pushed.

Comment 16

[Milos Dinic [:Milos]]

Thanks Jurk!