668835 - Add filter to get addToFirefox element for addons with versions for multiple platforms

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Maniac Vlad Florin (:vladmaniac)]

This is currently blocking our tests, because 

Some addons have different versions, depending on the platform
    This is how the HTML for the Add To Firefox Button looks for Last Pass
    <p class="install-button">
    <a class="button platform windows add installer" href="/firefox/downloads/latest/8542/platform:5/addon-8542-latest.xpi?src=discovery-promo" data-hash="sha256:a5a888521fd9cefcb99128dcd9f0fd75e08ba3e186c1e63ef216c2657444a7e5" target="_self">
    <a class="button platform linux add installer" href="/firefox/downloads/latest/8542/platform:2/addon-8542-latest.xpi?src=discovery-promo" data-hash="sha256:debed5b17a52f62ca98f1168bce29fe0b616aff1e76d58c8075207587b063a0f" target="_self">
    <a class="button platform mac add installer" href="/firefox/downloads/latest/8542/platform:3/addon-8542-latest.xpi?src=discovery-promo" data-hash="sha256:9aa73c5762637a09c977a6b21fa7ceb8420e91d3cacb306fbfdf224c9d3358e6" target="_self">
    <a class="button platform android add installer" href="/firefox/downloads/latest/8542/platform:7/addon-8542-latest.xpi?src=discovery-promo" data-hash="sha256:ecf4a8652426b27189febe7b48445185cbd9351bb03a8958158757854f36ac61" target="_self">
    </p>
    Only one has a CSS attribute: display: inline-block and the rest have display:none.
     
    For a regular addon this is how the HTML looks like:
    <p class="install-button">
    <a class="button add installer" href="/firefox/downloads/latest/3456/addon-3456-latest.xpi?src=discovery-promo" data-hash="sha256:c01d80d90c51b016f7540d409e29e45e1a7eb4e2b31ea02482c430754d9e3ab1" target="_self">
    </p>
     
    So when nodeCollector.queryNodes(".install-button a"); collects it, it gets all messed up. 
    This can affect all tests, and we need to fix this in the API

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: WIP v1

(In reply to comment #0)
>     Only one has a CSS attribute: display: inline-block and the rest have
> display:none.

Do you mean a property on the JS object? I don't think that this is a DOM attribute. That means we would have to change the nodeCollector line in addons.js to:

nodeCollector.queryNodes(".install-button a").filterByJSProperty("display", "inline-block");

Can you check if that works?

Comment 2

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/15283495

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Vlad, I need some help. Which add-on have you seen here? I can't find any of those which have multiple buttons. Thanks

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, this is the LastPass Password Manager. Investigation has shown that the nodeCollector needs a filterByCSSProperty method. I will come up with a solution by tomorrow.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

We have to use a workaround for now and work with the final computed CSS style as long as we do not have the active class set on the install button. With this patch we simply check if multiple buttons exist and filter the unwanted out.

This patch will also fix the test on bug 664019.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1

I had another patch in the queue. Here the correct patch.

Comment 7

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 543597 [details] [diff] [review]
Patch v1.1

Looks fine, please land.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/954a7b9e9e5d (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/1037d4dfbebf (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/0747c0fee7f7 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/2358a868afa4 (release)

Comment 9

[Maniac Vlad Florin (:vladmaniac)]

Thanks for being this quick Henrik. Sorry,  I was away for the weekend and hadn't mail access.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Any reason why you have reopened this bug? Closing as fixed again.

Comment 11

[Maniac Vlad Florin (:vladmaniac)]

I did not reopen the bug..dunno what happened

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Same for the platform again. Please ensure to not send any changes if mid-air collision are shown by Bugzilla.