668940 - IonMonkey: Split critical edges

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

This is needed for greedy regalloc and LSRA, so we might as well hoist it out into a very early MIR pass.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

I took this opportunity to get rid of loopSuccessor_ per bug 667132 because keeping explicit edge information around makes mutating it harder.

Comment 3

[Andrew Drake [:adrake]]

Comment on attachment 543560 [details] [diff] [review]
patch

Review of attachment 543560 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good otherwise!

::: js/src/ion/MIR.h
@@ +516,5 @@
>          JS_ASSERT(i < numSuccessors());
>          return successors[i];
>      }
> +
> +    void replaceEdge(size_t i, MBasicBlock *split) {

Nit: replaceSuccessor would probably be more accurate.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/users/danderson_mozilla.com/ionmonkey/rev/c6bcb9608c96 and a follow-up for nits