668993 - Sync account wizard does not close after clicking on "Finish"

Status: RESOLVED FIXED

(SeaMonkey :: Sync UI, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Set up a Sync account in SeaMonkey trunk via preferences
2. Get to the "Setup Complete" page in the wizard.
3. Click on "Finish"

Results:
Wizard dialog will not close, but the sync information page in the browser will open anyway (http://www.mozilla.com/en-US/firefox/sync/secondrun.html)

Maybe related: This error appears in the error console when clicking on the "Finish" button.
Error: Weave.Service.syncOnIdle is not a function
Source File: chrome://communicator/content/sync/syncSetup.js
Line: 510

Comment 1

[Frank Wein [:mcsmurf]]

Looks like http://hg.mozilla.org/mozilla-central/rev/6d462434be3a changed this in the FF code.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #1)
> Looks like http://hg.mozilla.org/mozilla-central/rev/6d462434be3a changed
> this in the FF code.

Right. I'm tracking Sync changes to browser/ locally but didn't have the time to look into them yet. Since you already identified the issue and I'll be AFK next week, I'd leave you the honor of being listed as the patch author for the one-liner which would fix this (just request review from Neil and push). Deal? :-)

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 4]

The change has already propagated to m-aurora, but not yet to m-beta.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 545071 [details] [diff] [review]
patch [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/22c588256c89
http://hg.mozilla.org/releases/comm-aurora/rev/3f57dc8c8349