66908 - Clicking in history sidebar opens new browser window

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect, P2)

Description

[Stephan Niemz]

1. Open the history sidebar
2. Double-click (see bug 66905) on an entry

Expected: that link is loaded in the same window
Actual:   a new browser window pops up with that link

Build 2001012820 on NT4 and recent CVS pull on Linux

Comment 1

[Alec Flett]

this is a big usability issue. I thought I had a dupe on this already, guess
not.

Comment 2

[Jesse Ruderman]

Ctrl-double-clicking should open the page in a new window, though.

Comment 3

[kurros (Wade Majors)]

...or middle clicking

Comment 4

[Alec Flett]

moving key 0.8 bugs that didn't make it to 0.9
(yes, these are important enough to keep, yadda yadda)

Comment 5

[Paul Chen]

Bumping off the mozilla0.9 train

Comment 6

[Alec Flett]

Attachment: easy fix

Comment 7

[Alec Flett]

Attachment: better fix

Comment 8

[Alec Flett]

looking for reviewer, super reviewer
this is consistent with the bookmarks panel.

Comment 9

[timeless]

r=timeless

Comment 10

[Jesse Ruderman]

event.metaKey?  Shouldn't the check be for Ctrl, at least on Windows?

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Is 'id' defined to something meaningful further up in the file? (I notice you 
pass id to openDialog but url to openTopWin...). If so, a=[e-mail]. 

Comment 12

[Alec Flett]

oops, I'm crazy. I changed that back to 'url' in my file and tested to make sure
it worked :)
fix going in later today

Comment 13

[Alec Flett]

cool, fix is in.

Comment 14

[Alec Flett]

oops, actually marking fixed

Comment 15

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]