669099 - Add developer whiteboard to add-on reviews

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Kris Maglione [:kmag]]

Add-on review pages should have a whiteboard field for information relevant to every review of an add-on. It should always appear on the review page, probably just below the version history. This field should be used for testing information, login credentials, or any other issue likely to be relevant to every review. This field should either be editable by editors as well as developers, or there should be a separate editor whiteboard.

I'm not sure where the field should appear from the developer perspective, but it should be preceded by text to the effect of:

  Whiteboard: Please use this field to include detailed testing information along with login credentials for a test account, if required, as well as any other notes to the reviewers likely to be relevant to all reviewed versions of your add-on.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

->me for mockup.

Comment 3

[Mathieu Agopian [:magopian]]

What is the use for this new whiteboard field? From what I understand, there's already a way for developers to submit "notes for reviewers" (per version), and a way to "comment" (only visible to other reviewers, per version).

How about displaying all the notes and comments at the bottom of the review page, so they're visible without having to go through all the "add-on history" tabs?

This would avoid cluttering the already pretty crowded forms (submission and review), while still answering the need to have all the notes and comments visible for all versions?

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Notes to reviewers and comments can be contextual, so displaying them all at the bottom would be a problem. We would lose context and probably accumulate lots of unneeded information.

We want a persistent field we can control and that is always displayed. Placing it always at the bottom of the review history sounds like a good idea. I also suggest that we don't use the same form used to submit the review. Instead I think we should have AJAX-y Edit and Save buttons for that field.

Comment 5

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/324

Comment 6

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/46fba7281cba5cf0a97c53a554ca603033100ca3

Comment 7

[Mathieu Agopian [:magopian]]

STR:
1/ as a developer, go to an addon listing in the devhub, which is waiting for a review
2/ edit the technical details and write something in the "whiteboard" field, then save it
3/ as an editor, go to the review page of this addon, and make sure the whiteboard with its content is visible at the bottom of the page
4/ edit the whiteboard content and save it
5/ as the developer you should now see the new content once you refresh the page

Comment 8

[Madalin Cotetiu]

Verified as fixed in FF33(Win7) in addons-dev.allizom.org
Postfix screencast: http://screencast.com/t/XRqTCHRC

Comment 9

[rctgamer3]

(In reply to Madalin Cotetiu from comment #8)
> Verified as fixed in FF33(Win7) in addons-dev.allizom.org
> Postfix screencast: http://screencast.com/t/XRqTCHRC
Screencast is broken.

Comment 10

[Madalin Cotetiu]

(In reply to rctgamer3 from comment #9)
> (In reply to Madalin Cotetiu from comment #8)
> > Verified as fixed in FF33(Win7) in addons-dev.allizom.org
> > Postfix screencast: http://screencast.com/t/XRqTCHRC
> Screencast is broken.

Try this one: http://screencast.com/t/EjQM7fDIT