669103 - TypeError: memory.track is not a function in observer-service.js when a package includes its own memory.js module

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Nickolay_Ponomarev]

(Add-on SDK 1.0)

If you have a lib/memory.js in your package, cfx test will fail with:

error: An exception occurred.
Traceback (most recent call last):
  File "resource://***-api-utils-lib/observer-service.js", line 92, in add
  File "resource://***-api-utils-lib/observer-service.js", line 150, in Observer
TypeError: memory.track is not a function
FAIL

Having spent 15 minutes trying to figure it out (in hindsight it was obvious), I feel I should log this for others who might encounter this issue.


This might also be an issue with other built-in modules, in which case it might be worth to implement some kind of sanity check for this in cfx.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Irakli, can you take a look at this?
I think it's just needing to explicitly specify the SDK's memory library.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Nickolay, Wes I believe this was fixed by:
https://bugzilla.mozilla.org/show_bug.cgi?id=672087

I've tested by creating memory.js in annotator example an everything seems to work fine. Nickolay can you please test your case with a code from master and see if you can still reproduce this ?

Comment 3

[Nickolay_Ponomarev]

Thanks! I think we can close this, since I'd test it exactly as you did and it doesn't seem to be worth the extra check.

Comment 4

[Nickolay_Ponomarev]

By the way: Wes, it's great to have you as the bugmaster! Thanks a lot for going through the bugs.