669129 - Deleting autocomplete result and hitting Enter should not load the deleted URL

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P3)

Description

[Jonathan Watt [:jwatt]]

If I type something into the address bar, use the arrow keys to highlight one of the suggestions, delete it (using the Del key on win/linux or shift+backspace on mac), then hit Enter immediately, the URL of the deleted entry is loaded.

I would /guess/ whats happening here is that when using the arrow keys to highlight an entry some state for "URL to load" is updated, but when an entry is deleted that URL is not updated to the URL for the item that is now selected. If someone can point me to the relevant code I'd be happy to submit a patch.

Comment 1

[Jonathan Watt [:jwatt]]

Uh, where the "some state" is the address bar itself, of course.

Comment 2

[Dão Gottwald [:dao]]

I can't reproduce this.

Comment 3

[Jonathan Watt [:jwatt]]

Please describe what you did, and what happened to the address in the address bar when you deleted an entry from the suggestions.

Comment 4

[Dão Gottwald [:dao]]

I misread comment 0, can reproduce it now.

Involved code:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/autocomplete.xml#498
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/nsAutoCompleteController.cpp#545

Comment 6

[Loic]

Still in FF9, minor bug but annoying during the daily use of the awesome bar.
As FF selects/highligths the next URL following the deleted URL, the location bar should display this URL or nothing (blank) if there is no next URL.

Comment 7

[alex_mayorga]

An add-on fixes this annoyance[1].

Perhaps someone could turn it into an actual patch.

[1] https://addons.mozilla.org/en-US/firefox/addon/bug669129/

Comment 9

[rb]

I want to work on this bug. Can it be assigned to me?

Comment 11

[locutus266]

Still confirmed in FF 18.0.2

Comment 12

[Loic]

Gijs, I CC'd you to this bug, I know you work on location bar, so maybe one day in the future, you'll have cycles and time to work on it. It's a minor bug but annoying sometimes.

Comment 13

[:Gijs (he/him)]

rb, I'm assuming you're no longer working on this... please let us know if you are still.

Comment 14

[locutus266]

Actually, this bug seems to be gone by now.

Comment 15

[Loic]

No, it's still here in FF37.

Comment 17

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

would be interesting to retest this and blocked bugs after bug 1236364 is in a nightly.

Comment 18

[:Gijs (he/him)]

(In reply to Marco Bonardo [::mak] from comment #17)
> would be interesting to retest this and blocked bugs after bug 1236364 is in
> a nightly.

Sadly, doesn't seem fixed to me on Nightly... can you doublecheck?

Comment 19

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

yep, looks like there's more. Off-hand sounds like we don't update the input field synchronously on a removal.

Comment 20

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I can't reproduce in Quantum Bar (tested in Nightly, but Beta should be the same(. Feel free to reopen if you still see this. Note now you must use SHIFT+DEL to remove an entry.

Comment 21

[avada]

(In reply to Marco Bonardo [::mak] from comment #20)

I can't reproduce in Quantum Bar (tested in Nightly, but Beta should be the same(. Feel free to reopen if you still see this. Note now you must use SHIFT+DEL to remove an entry.

No wonder since deleting an item doesn't work at all. It's broken, or not implemented.

Comment 22

[Mark Banner (:standard8)]

(In reply to avada from comment #21)

No wonder since deleting an item doesn't work at all. It's broken, or not implemented.

Did you notice that it is now shift-del rather than just delete? It has been working fine for us. If you still have issues, please file a new bug preferably a screenshot and any messages appearing on the browser console when you're attempting to open up the address bar results and then shift-delete.

Comment 23

[avada]

(In reply to Mark Banner (:standard8) from comment #22)

(In reply to avada from comment #21)

No wonder since deleting an item doesn't work at all. It's broken, or not implemented.

Did you notice that it is now shift-del rather than just delete? It has been working fine for us. If you still have issues, please file a new bug preferably a screenshot and any messages appearing on the browser console when you're attempting to open up the address bar results and then shift-delete.

I see. It's a counter intuitive change, but the the bug is in fact not present now.