Deleting autocomplete result and hitting Enter should not load the deleted URL

NEW
Unassigned

Status

()

Firefox
Address Bar
P3
major
Rank:
37
7 years ago
2 years ago

People

(Reporter: jwatt, Unassigned)

Tracking

(Blocks: 3 bugs)

Trunk
Points:
8
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite ?
qe-verify +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [unifiedcomplete][fxsearch])

If I type something into the address bar, use the arrow keys to highlight one of the suggestions, delete it (using the Del key on win/linux or shift+backspace on mac), then hit Enter immediately, the URL of the deleted entry is loaded.

I would /guess/ whats happening here is that when using the arrow keys to highlight an entry some state for "URL to load" is updated, but when an entry is deleted that URL is not updated to the URL for the item that is now selected. If someone can point me to the relevant code I'd be happy to submit a patch.
Uh, where the "some state" is the address bar itself, of course.
I can't reproduce this.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Please describe what you did, and what happened to the address in the address bar when you deleted an entry from the suggestions.
I misread comment 0, can reproduce it now.

Involved code:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/autocomplete.xml#498
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/nsAutoCompleteController.cpp#545
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Mac OS X → All
Hardware: x86 → All
Summary: Deleting from the address bar dropdown then hitting Enter should not load the deleted URL → Deleting autocomplete result and hitting Enter should not load the deleted URL
Duplicate of this bug: 691062

Comment 6

6 years ago
Still in FF9, minor bug but annoying during the daily use of the awesome bar.
As FF selects/highligths the next URL following the deleted URL, the location bar should display this URL or nothing (blank) if there is no next URL.

Comment 7

6 years ago
An add-on fixes this annoyance[1].

Perhaps someone could turn it into an actual patch.

[1] https://addons.mozilla.org/en-US/firefox/addon/bug669129/

Updated

6 years ago
Duplicate of this bug: 726475

Comment 9

5 years ago
I want to work on this bug. Can it be assigned to me?

Updated

5 years ago
Assignee: nobody → rahul123bhardwaj
Blocks: 777277
Duplicate of this bug: 725980

Comment 11

5 years ago
Still confirmed in FF 18.0.2

Comment 12

3 years ago
Gijs, I CC'd you to this bug, I know you work on location bar, so maybe one day in the future, you'll have cycles and time to work on it. It's a minor bug but annoying sometimes.

Comment 13

3 years ago
rb, I'm assuming you're no longer working on this... please let us know if you are still.
Assignee: rahul123bhardwaj → nobody
Points: --- → 8
Flags: qe-verify+
Flags: in-testsuite?
Flags: firefox-backlog+

Comment 14

3 years ago
Actually, this bug seems to be gone by now.

Comment 15

3 years ago
No, it's still here in FF37.
Blocks: 1071461
Priority: -- → P3
Whiteboard: [unifiedcomplete][fxsearch]

Updated

2 years ago
Rank: 37
Severity: normal → major

Updated

2 years ago
Duplicate of this bug: 1239663

Updated

2 years ago
Blocks: 1239663
Depends on: 1236364
would be interesting to retest this and blocked bugs after bug 1236364 is in a nightly.

Comment 18

2 years ago
(In reply to Marco Bonardo [::mak] from comment #17)
> would be interesting to retest this and blocked bugs after bug 1236364 is in
> a nightly.

Sadly, doesn't seem fixed to me on Nightly... can you doublecheck?
Flags: needinfo?(mak77)
yep, looks like there's more. Off-hand sounds like we don't update the input field synchronously on a removal.
Flags: needinfo?(mak77)
You need to log in before you can comment on or make changes to this bug.