Closed
Bug 669188
Opened 13 years ago
Closed 13 years ago
Flag "browser.preferences.instantApply" preference in validator
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
VERIFIED
FIXED
6.1.7
People
(Reporter: jorgev, Assigned: basta)
Details
Attachments
(1 file)
|
192.29 KB,
image/png
|
Details |
post-fix screenshot
Setting the "browser.preferences.instantApply" preference in an extension can lead to UI problems, like in bug 641288. We need to flag it in the validator. We should just check for any instance of "browser.preferences.instantApply", and show a general warning saying something like: "Changing the value of this preference can lead to UI problems in the browser".
|
Assignee | |
Comment 1•13 years ago
|
||
Done: https://github.com/mattbasta/amo-validator/commit/3ab4a224b037dddf87fafde087189f7280acb37d
|
||
Updated•13 years ago
|
Target Milestone: 6.1.4 → 6.1.5
|
||
Updated•13 years ago
|
Target Milestone: 6.1.5 → 6.1.6
|
|
Assignee | |
Comment 2•13 years ago
|
||
Merged: https://github.com/mozilla/amo-validator/commit/656c03c420816cefebcc45148c11c72d7df890e4
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•13 years ago
|
||
Reopened to start testing all files
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 4•13 years ago
|
||
reopening since the warning doesn't show up for https://addons.mozilla.org/en-US/firefox/addon/youtube-tooltip/ https://addons.mozilla.org/en-US/firefox/addon/nicofox/
|
|
Assignee | |
Comment 5•13 years ago
|
||
Done: https://github.com/mattbasta/amo-validator/commit/55aa9025749b3a63176b4c6618c6fdbe0a81ac12
|
|
||
Updated•13 years ago
|
Target Milestone: 6.1.6 → 6.1.7
|
|
Assignee | |
Comment 6•13 years ago
|
||
Merged: https://github.com/mozilla/amo-validator/commit/2d874e862b889c491a2fb7f67839b77a9e6c8008
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•13 years ago
|
||
verified fixed at https://addons.allizom.org/en-US/developers/upload/3c762bc0828a4556af3ed57e90258e6f
Status: RESOLVED → VERIFIED
|
|
||
Comment 8•13 years ago
|
||
|
||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•