Closed Bug 669217 Opened 10 years ago Closed 10 years ago

Remove nsISecurityCheckedComponent from videocontrols

Categories

(Toolkit :: Video/Audio Controls, defect)

Product:
Toolkit
Component:
Video/Audio Controls
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: Dolske, Assigned: Dolske)

Details

Attachments

(1 file)

Patch v.1
1.96 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
Attached patch Patch v.1 — — Splinter Review 
There's been some prior discussion of this interface in the past -- bug 470852, and notably bug 475864. As I understand things (poorly ;), this code isn't actually doing anything now, and I recall bz saying something long ago to the effect of we should be able to remove it once we're ok with the then-new quickstubs code.
Attachment #543818 - Flags: review?(bzbarsky)
Comment on attachment 543818 [details] [diff] [review]
Patch v.1

I don't remember the security implications here very well.  :(  Blake, can you take a look?
Attachment #543818 - Flags: review?(bzbarsky) → review?(mrbkap)
Comment on attachment 543818 [details] [diff] [review]
Patch v.1

I have vague memories of the conversations around this. I'm pretty sure that because we removed the native anonymous content check in nsScriptSecurityManager, this implementation of nsISecurityCheckedComponent is no longer needed.
Attachment #543818 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/mozilla-central/rev/5c7fc05dc9e3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.