Closed Bug 669285 Opened 10 years ago Closed 10 years ago

Look into if we should give some color to the sidebar

Categories

(Thunderbird :: Theme, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 8.0

People

(Reporter: andreasn, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Similar to bug #614215 where we give some color to the sidebar under Aero, it might be good to do so under Linux as well, especially with the smaller resize grips in bug #666232

One possibility would be to use a very, very light tint of Highlight or perhaps -moz-EvenTreeRow. Both of these might cause issues under certain themes.

That said, it might work well without any sidebar color as well.
Blocks: 665873
I'm using -moz-OddTreeRow instead of -moz-EvenTreeRow. This gives the darker background.
I tested with all my installed themes and it works with every one.

This patch needs bug 666232 applied.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #544984 - Flags: ui-review?(nisses.mail)
If you like this patch I can also add the background-color to the addressbook's directory tree.
Comment on attachment 544984 [details] [diff] [review]
Give folderTree background-color: -moz-OddTreeRow

Looks good and works on all themes I tried.
Attachment #544984 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 544984 [details] [diff] [review]
Give folderTree background-color: -moz-OddTreeRow

This is also Linux only
Attachment #544984 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 544984 [details] [diff] [review]
Give folderTree background-color: -moz-OddTreeRow

Review of attachment 544984 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #544984 - Flags: review?(squibblyflabbetydoo) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/8cc237a58058
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 8.0
On a personal note, I'm going to have a hard time getting used to this, but well...

Screenshot: <http://jonathan.protzenko.free.fr/shutter/Selection_014.png>
(In reply to comment #7)
> On a personal note, I'm going to have a hard time getting used to this, but
> well...

Ditto. Which is especially odd for me since I'm used to the folder pane being a different color in Windows. Oh well.
Yeah, I don't like the grey sidebar color either, looks like a part of the menu, at least on Fedora (http://people.redhat.com/stransky/thunderbird.png)
(In reply to Martin Stránský from comment #9)
> Yeah, I don't like the grey sidebar color either, looks like a part of the
> menu, at least on Fedora (http://people.redhat.com/stransky/thunderbird.png)

How would that look with the GTK3 theme?
Both Nautilus and GTK filechooser does a gray sidebar on Fedora these days. OddTreeRow is white in Adwaita though, so I guess we would end up with a all white sidebar again.
You need to log in before you can comment on or make changes to this bug.