669345 - Add support for radio button elements for inline preferences

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110630 Firefox/7.0a1

We don't support radio buttons for inline preferences yet. I think that a lot of add-ons would benefit from its availability.

Comment 1

[Mozilla RelEng Bot]

Try run for 64c44d9e8629 is complete.
Detailed breakdown of the results available here:
    http://tbpl.mozilla.org/?tree=Try&rev=64c44d9e8629
Results:
    success: 13
    warnings: 4
Total buildrequests: 17
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-64c44d9e8629

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: patch

I wanted to do this without requiring a <radiogroup>, but the radio buttons won't work inside anonymous content.

(The try warnings are unrelated.)

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: patch with other pref types

I've changed the logic to also accept bool or char prefs.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 549556 [details] [diff] [review]
patch with other pref types

Review of attachment 549556 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/content/setting.xml
@@ +491,5 @@
> +        <![CDATA[
> +          let self = this;
> +          this.radioGroup.addEventListener("command", function() {
> +            self.valueToPreference();
> +          }, false);

If you wanted to, you could instead do:

this.radioGroup.addEventListener("command", this.valueToPreference.bind(this), false);

(I only mention it because its new, few people know about it, and I think it's nicer.)

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/9230c6aa00ea

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Backed out due to either this or bug 669390 leaking. No idea whats going on, but it started happening with that push - on all debug builds.
https://hg.mozilla.org/integration/fx-team/rev/51d7ece2bb10


http://tinderbox.mozilla.org/showlog.cgi?log=Fx-Team/1312863307.1312868107.7800.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Fx-Team/1312863348.1312867944.7375.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Fx-Team/1312867017.1312871451.22166.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Fx-Team/1312862532.1312866829.2356.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Fx-Team/1312865060.1312868669.9847.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Fx-Team/1312862109.1312866139.32626.gz

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: patch v3

Comment 8

[Dão Gottwald [:dao]]

patching file toolkit/themes/pinstripe/mozapps/extensions/extensions.css
Hunk #1 FAILED at 1092
1 out of 1 hunks FAILED -- saving rejects to file toolkit/themes/pinstripe/mozapps/extensions/extensions.css.rej
patching file toolkit/themes/winstripe/mozapps/extensions/extensions.css
Hunk #1 FAILED at 1114
1 out of 1 hunks FAILED -- saving rejects to file toolkit/themes/winstripe/mozapps/extensions/extensions.css.rej

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: patch v4

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d7d667d640b2

Noting the reviewer in your commit message is helpful

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/d7d667d640b2

Comment 12

[Geoff Lankow (:darktrojan)]

https://developer.mozilla.org/en/Extensions/Inline_Options updated.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Geoff, the example extension you have uploaded lately as attachment to another bug, is it part of the tree? If yes, where can I find it? I would like to have an updated one with all the new features included. Thanks.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I have updated the other example extension meanwhile on my own. And it looks great. Verified fixed on all platforms with builds like Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0a2) Gecko/20110824 Firefox/8.0a2