File and Directory paths should be cropped in the middle and not at the beginning of the path

RESOLVED FIXED in mozilla12

Status

()

defect
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: whimboo, Assigned: darktrojan)

Tracking

7 Branch
mozilla12
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110703 Firefox/7.0a1

The paths for files and directories are getting cropped at the beginning of the string. Instead we should crop and display ellipses in the middle of the string to give the user the chance to see the root path. Otherwise it's hard to figure out which file has been selected.
Posted image screenshot
Version: 5 Branch → 7 Branch
Assignee

Comment 2

8 years ago
Posted patch patch (obsolete) — Splinter Review
I'm not really a fan of cropping in the middle either, but I think it probably is better than at the start. I've also added a minimum width to the left-hand column to stop it getting swamped by a large filename in the right-hand column.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #553652 - Flags: review?(bmcbride)
Where are these paths appearing?

What I usually do in such cases is:

a) provide a tooltip with the full path.

b) Use a textbox to display the path. It can be styled to not look like a textbox, and the user can copy the path.
Agreed with comment 3. When cropping text, the full text at least needs to show in a tooltip.

Being able to select and copy the path has some utility, but it makes the usual case of just reading the path less nice (since it essentially crops at the end, until you explicitly force the end to scroll into view).

Deferring to UX.
Keywords: uiwanted
Comment on attachment 553652 [details] [diff] [review]
patch

Review of attachment 553652 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed with comment 3. When cropping text, the full text at least needs to show in a tooltip.

Being able to
Attachment #553652 - Flags: review?(bmcbride) → review-
Er, ignore comment 5. Was meant to be just the r-
(In reply to Blair McBride (:Unfocused) from comment #4)
> Agreed with comment 3. When cropping text, the full text at least needs to
> show in a tooltip.
> 
> Being able to select and copy the path has some utility, but it makes the
> usual case of just reading the path less nice (since it essentially crops at
> the end, until you explicitly force the end to scroll into view).
> 
> Deferring to UX.

I agree, let's crop in the middle with "..." and show the full string in a tooltip.
Keywords: uiwanted
Assignee

Comment 8

8 years ago
Posted patch patch v2Splinter Review
Attachment #553652 - Attachment is obsolete: true
Attachment #590443 - Flags: review?(bmcbride)
Attachment #590443 - Flags: review?(bmcbride) → review+
Assignee

Comment 9

8 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d9846b8eb28
Flags: in-testsuite+
Flags: in-litmus-
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/2d9846b8eb28
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.