Open button functionality in Search dialog

VERIFIED FIXED in mozilla0.8

Status

P2
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: gayatrib, Assigned: gayatrib)

Tracking

Trunk
mozilla0.8
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta1+])

Attachments

(2 attachments)

(Assignee)

Description

18 years ago
Add open button functionality to the search dialog.
(Assignee)

Comment 1

18 years ago
adding nsbeta1 keyword and accepting the bug.
Status: NEW → ASSIGNED
Keywords: nsbeta1

Comment 2

18 years ago
If you mean "open to folder where message is located", then that is already
covered in bug 56419.
QA Contact: esther → laurel

Comment 3

18 years ago
Nevermind, I forgot the spec showed Open button just for opening message to
standalone window.

Comment 4

18 years ago
marking nsbeta1+ and moving to mozilla0.8
Priority: -- → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.8
(Assignee)

Comment 5

18 years ago
Fix in hand. Works for both single and multiple messages open. Attaching patch.
(Assignee)

Comment 6

18 years ago
Created attachment 23903 [details] [diff] [review]
patch
(Assignee)

Comment 7

18 years ago
Adding patch, review keywords.
Adding seth, david to cc list for reviews/super reviews.
Keywords: patch, review
(Assignee)

Comment 8

18 years ago
Making this dependent on bug 66958. I tested it with the patch taka provided in 
that bug.
Depends on: 66958
(Assignee)

Updated

18 years ago
No longer depends on: 66958
a lot of that code looks copied from mailWindowOverlay.js

can you find a way to do this, without copying code?

what happens if no messages are selected and I click on the open button.

can you make it so we disable / enable the open button based on the selection?

Comment 10

18 years ago
Wouldn't it be confusing to have an "Open" button (which opens the selected 
messages) next to a "Close" button (which closes the search window)?  I suggest 
putting "Open" and other items that have to do with selected messages at the 
left edge of the window, or making those commands only show up on the context 
menu (bug 66970) for the tree items.
(Assignee)

Comment 11

18 years ago
fix in hand. attaching patch. please review/super review asap as i can get this 
in today if it is fine.
(Assignee)

Comment 12

18 years ago
Created attachment 24607 [details] [diff] [review]
patch

Comment 13

18 years ago
sr=bienvenu

Comment 14

18 years ago
r=racham.
(Assignee)

Comment 15

18 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 16

18 years ago
OK using feb 8 commercial trunk builds with win98, linux rh6.0 and mac OS 9.0
Status: RESOLVED → VERIFIED

Comment 17

18 years ago
Oh yeah, forgot to add:
Works for both single and multiple selection (separate windows opened for each
message in a multiple selection Open).
Also logged a bug to move the Open (and File, Delete buttons when they are
implemented) to the right of the results pane per spec. (spec not available on
mozilla yet)
Product: Browser → Seamonkey

Updated

10 years ago
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.