The default bug view has changed. See this FAQ.

Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function]

RESOLVED FIXED in mozilla8

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla8
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

fix
845 bytes, patch
Joe Drew (not getting mail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
It looks like this function became unused after
(Assignee)

Comment 1

6 years ago
It looks like this function became unused after nsRect::ExtendForScaling was removed, and so is no longer needed.
(Assignee)

Comment 2

6 years ago
Created attachment 544105 [details] [diff] [review]
fix

Fix removes the now-unused function.
Attachment #544105 - Flags: review?(joe)
Comment on attachment 544105 [details] [diff] [review]
fix

Looks good. Be sure to push this to try for a compile only. 

http://people.mozilla.org/~lsblakk/trychooser/trychooser.html
Attachment #544105 - Flags: review?(joe) → review+
Blocks: 187528
Whiteboard: [build_warning]
Summary: Build warning: gfx/src/nsRect.cpp:51:13: warning: ‘bool IsFloatInteger(float)’ defined but not used [-Wunused-function] Build warning: gfx/src/nsRect.cpp:51:13: warning: ‘bool IsFloatInteger(float)’ defined but not used [-Wunused-function] → Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function] Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function]
Status: NEW → ASSIGNED
(Assignee)

Comment 4

6 years ago
Try builds were successful:
http://tbpl.mozilla.org/?tree=Try&rev=2a312ec865bc
Keywords: checkin-needed
Landed this earlier today -- I thought I noted it here but I guess I didn't. :)
http://hg.mozilla.org/integration/mozilla-inbound/rev/aaeabf9d44d4
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][inbound]
Merged:
http://hg.mozilla.org/mozilla-central/rev/aaeabf9d44d4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [build_warning][inbound] → [build_warning]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.