Closed
Bug 669522
Opened 13 years ago
Closed 13 years ago
Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function]
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: jgilbert, Assigned: jgilbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
845 bytes,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
It looks like this function became unused after
|
Assignee | |
Comment 1•13 years ago
|
||
It looks like this function became unused after nsRect::ExtendForScaling was removed, and so is no longer needed.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Fix removes the now-unused function.
Attachment #544105 -
Flags: review?(joe)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 544105 [details] [diff] [review] fix Looks good. Be sure to push this to try for a compile only. http://people.mozilla.org/~lsblakk/trychooser/trychooser.html
Attachment #544105 -
Flags: review?(joe) → review+
|
||
Updated•13 years ago
|
Blocks: buildwarning
Whiteboard: [build_warning]
|
|
||
Updated•13 years ago
|
Summary: Build warning: gfx/src/nsRect.cpp:51:13: warning: ‘bool IsFloatInteger(float)’ defined but not used [-Wunused-function] Build warning: gfx/src/nsRect.cpp:51:13: warning: ‘bool IsFloatInteger(float)’ defined but not used [-Wunused-function] → Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function] Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function]
|
||
Updated•13 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•13 years ago
|
||
Try builds were successful: http://tbpl.mozilla.org/?tree=Try&rev=2a312ec865bc
Keywords: checkin-needed
|
|
||
Comment 5•13 years ago
|
||
Landed this earlier today -- I thought I noted it here but I guess I didn't. :) http://hg.mozilla.org/integration/mozilla-inbound/rev/aaeabf9d44d4
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][inbound]
|
||
Comment 6•13 years ago
|
||
Merged: http://hg.mozilla.org/mozilla-central/rev/aaeabf9d44d4
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [build_warning][inbound] → [build_warning]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•