Closed Bug 669522 Opened 9 years ago Closed 9 years ago

Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function]

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

It looks like this function became unused after
It looks like this function became unused after nsRect::ExtendForScaling was removed, and so is no longer needed.
Attached patch fixSplinter Review
Fix removes the now-unused function.
Attachment #544105 - Flags: review?(joe)
Comment on attachment 544105 [details] [diff] [review]
fix

Looks good. Be sure to push this to try for a compile only. 

http://people.mozilla.org/~lsblakk/trychooser/trychooser.html
Attachment #544105 - Flags: review?(joe) → review+
Summary: Build warning: gfx/src/nsRect.cpp:51:13: warning: ‘bool IsFloatInteger(float)’ defined but not used [-Wunused-function] Build warning: gfx/src/nsRect.cpp:51:13: warning: ‘bool IsFloatInteger(float)’ defined but not used [-Wunused-function] → Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function] Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function]
Status: NEW → ASSIGNED
Landed this earlier today -- I thought I noted it here but I guess I didn't. :)
http://hg.mozilla.org/integration/mozilla-inbound/rev/aaeabf9d44d4
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][inbound]
Merged:
http://hg.mozilla.org/mozilla-central/rev/aaeabf9d44d4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [build_warning][inbound] → [build_warning]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.