Last Comment Bug 669522 - Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)' defined but not used [-Wunused-function]
: Build warning: gfx/src/nsRect.cpp:51:13: warning: 'bool IsFloatInteger(float)...
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla8
Assigned To: Jeff Gilbert [:jgilbert]
: Milan Sreckovic [:milan]
Depends on:
Blocks: buildwarning 637852
  Show dependency treegraph
Reported: 2011-07-05 16:59 PDT by Jeff Gilbert [:jgilbert]
Modified: 2011-07-12 03:47 PDT (History)
4 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (845 bytes, patch)
2011-07-05 17:24 PDT, Jeff Gilbert [:jgilbert]
joe: review+
Details | Diff | Splinter Review

Description User image Jeff Gilbert [:jgilbert] 2011-07-05 16:59:44 PDT
It looks like this function became unused after
Comment 1 User image Jeff Gilbert [:jgilbert] 2011-07-05 17:01:11 PDT
It looks like this function became unused after nsRect::ExtendForScaling was removed, and so is no longer needed.
Comment 2 User image Jeff Gilbert [:jgilbert] 2011-07-05 17:24:19 PDT
Created attachment 544105 [details] [diff] [review]

Fix removes the now-unused function.
Comment 3 User image Joe Drew (not getting mail) 2011-07-06 08:36:09 PDT
Comment on attachment 544105 [details] [diff] [review]

Looks good. Be sure to push this to try for a compile only.
Comment 4 User image Jeff Gilbert [:jgilbert] 2011-07-11 12:13:29 PDT
Try builds were successful:
Comment 5 User image Daniel Holbert [:dholbert] (vacation, returning 2/27) 2011-07-11 18:22:00 PDT
Landed this earlier today -- I thought I noted it here but I guess I didn't. :)
Comment 6 User image Mounir Lamouri (:mounir) 2011-07-12 03:47:36 PDT

Note You need to log in before you can comment on or make changes to this bug.