669540 - security_broken.tiff and security_lock.tiff have different bodies

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: the original icons

The 100¥ (1.1usd!) question: which one is preferred ? Personally, I prefer the look of security_lock; it matches most of the other icons.

Comment 1

[philippe (part-time)]

Attachment: updated security_broken icon

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #0)
> Created attachment 544127 [details]
> the original icons
> 
> The 100¥ (1.1usd!) question: which one is preferred ? Personally, I prefer
> the look of security_lock; it matches most of the other icons.

As do I.  _broken looks like it was old and never updated during some refresh (though CVS history tells me otherwise), or perhaps corrupted during some optimization checkin.

How does this interact with bug 626947?

Comment 3

[philippe (part-time)]

(In reply to comment #2)
 
> How does this interact with bug 626947?
I'd have to update the icon there (which basically boils down to cutting away 1 px column out of the canvas - trivial)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 544128 [details]
updated security_broken icon

r=ardissone, then.  Looks like this one saves a few hundred bytes, too!

Comment 5

[philippe (part-time)]

(In reply to comment #4)

> Looks like this one saves a few hundred bytes, too!

The images as currently in the tree are uncompressed. Do you want a compressed security_lock ? File size goes down from 1218 bytes to 698 bytes.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #5)
> (In reply to comment #4)
> 
> > Looks like this one saves a few hundred bytes, too!
> 
> The images as currently in the tree are uncompressed. Do you want a
> compressed security_lock ? File size goes down from 1218 bytes to 698 bytes.

Assuming we get to bug 626947, we should just pick it up with that bug; I'll let Stuart comment on the likelihood of that.

Comment 7

[Stuart Morgan]

Oops, I forgot about that bug. I'll do the code side of that ASAP, and we can land that plus fixed, shaved image files.

Comment 8

[Stuart Morgan]

Comment on attachment 544128 [details]
updated security_broken icon

sr=smorgan on landing these now since I'm behind on the other bug and not sure when I'll finish it.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Smokey Ardisson (offline for a while; no bugmail - do not email) from comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > 
> > > Looks like this one saves a few hundred bytes, too!
> > 
> > The images as currently in the tree are uncompressed. Do you want a
> > compressed security_lock ? File size goes down from 1218 bytes to 698 bytes.
> 
> Assuming we get to bug 626947, we should just pick it up with that bug; I'll
> let Stuart comment on the likelihood of that.

I guess we'll get the compressed security_lock if we get to bug 626947; as I read that bug, if we landed the (sized-to-width) images from there, they'd be blurry in the UI until the code fix was in, so we don't want that.

http://hg.mozilla.org/camino/rev/c926965fdf73

Comment 10

[philippe (part-time)]

Attachment: compressed security_lock

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/246897307eb3 for the compressed security_lock, with the understanding from comment 8 that we wanted the "most current" useable versions of both landed.