66958 - Search messages: Crash when initiating search

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[laurel]

Using 2001-01-29-04 commercial trunk build Win98
Haven't yet gotten to today's builds on other platforms...

Clicking on Search button to initiate a simple search messages crashes.  No
talkback report(s).

Comment 1

[laurel]

Seems to be IMAP only, OK for POP and news.
Happens on linux using jan29 commercial trunk build -- exits application.

Comment 2

[scottputterman]

marking nsbeta1+ and moving to mozilla0.8

It would be great if we could get a stack trace from talkback or from a debug
build.  

Comment 3

[gayatrib]

I tried this on Win NT using today's build. Running into same problem. Posting 
the stack trace.

Comment 4

[gayatrib]

strlen() line 78
nsCRT::strlen(const char * 0x00000000) line 136 + 9 bytes
nsMsgSearchAdapter::EncodeImapTerm(nsIMsgSearchTerm * 0x06e39430, int 0, const 
unsigned short * 0x0012d5fc, const unsigned short * 0x0012d5fc, char * * 
0x06f1afb0) line 617 + 206 bytes
nsMsgSearchAdapter::EncodeImap(char * * 0x0012d5dc, nsISupportsArray * 
0x06e60650, const unsigned short * 0x0012d5fc, const unsigned short * 
0x0012d5fc, int 0) line 708 + 36 bytes
nsMsgSearchOnlineMail::Encode(nsCString & {...}, nsISupportsArray * 0x06e60650, 
const unsigned short * 0x06f19230) line 156 + 126 bytes
nsMsgSearchOnlineMail::ValidateTerms(nsMsgSearchOnlineMail * const 0x06f192d0) 
line 55 + 34 bytes
nsMsgSearchScopeTerm::InitializeAdapter(nsISupportsArray * 0x06e60650) line 1418 
+ 26 bytes
nsMsgSearchSession::Initialize() line 465 + 20 bytes
nsMsgSearchSession::Search(nsMsgSearchSession * const 0x06e66900, nsIMsgWindow * 
0x06ea6e30) line 308 + 8 bytes
XPTC_InvokeByIndex(nsISupports * 0x06e66900, unsigned int 20, unsigned int 1, 
nsXPTCVariant * 0x0012d8e4) line 139
nsXPCWrappedNativeClass::CallWrappedMethod(JSContext * 0x057d64a0, 
nsXPCWrappedNative * 0x06ea2bc0, const XPCNativeMemberDescriptor * 0x06ea0e10, 
nsXPCWrappedNativeClass::CallMode CALL_METHOD, unsigned int 1, long * 
0x03510f0c, long * 0x0012dacc) line 920 + 42 bytes
WrappedNative_CallMethod(JSContext * 0x057d64a0, JSObject * 0x034dd718, unsigned 
int 1, long * 0x03510f0c, long * 0x0012dacc) line 250 + 34 bytes
js_Invoke(JSContext * 0x057d64a0, unsigned int 1, unsigned int 0) line 777 + 23 
bytes
js_Interpret(JSContext * 0x057d64a0, long * 0x0012e878) line 2670 + 15 bytes
js_Invoke(JSContext * 0x057d64a0, unsigned int 1, unsigned int 2) line 794 + 13 
bytes
js_InternalInvoke(JSContext * 0x057d64a0, JSObject * 0x034dd080, long 55437896, 
unsigned int 0, unsigned int 1, long * 0x0012ea10, long * 0x0012e9a0) line 866 + 
20 bytes
JS_CallFunctionValue(JSContext * 0x057d64a0, JSObject * 0x034dd080, long 
55437896, unsigned int 1, long * 0x0012ea10, long * 0x0012e9a0) line 3264 + 31 
bytes
nsJSContext::CallEventHandler(nsJSContext * const 0x057d6b80, void * 0x034dd080, 
void * 0x034dea48, unsigned int 1, void * 0x0012ea10, int * 0x0012ea0c, int 0) 
line 931 + 33 bytes
nsJSEventListener::HandleEvent(nsIDOMEvent * 0x06e9fd14) line 154 + 64 bytes
nsEventListenerManager::HandleEventSubType(nsListenerStruct * 0x06d71a10, 
nsIDOMEvent * 0x06e9fd14, nsIDOMEventTarget * 0x06d71b68, unsigned int 8, 
unsigned int 7) line 838 + 19 bytes
nsEventListenerManager::HandleEvent(nsIPresContext * 0x057a27e0, nsEvent * 
0x0012f2b0, nsIDOMEvent * * 0x0012f248, nsIDOMEventTarget * 0x06d71b68, unsigned 
int 7, nsEventStatus * 0x0012f2f4) line 1720 + 39 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x06d71b60, nsIPresContext * 
0x057a27e0, nsEvent * 0x0012f2b0, nsIDOMEvent * * 0x0012f248, unsigned int 1, 
nsEventStatus * 0x0012f2f4) line 3455
PresShell::HandleDOMEventWithTarget(PresShell * const 0x057df5a0, nsIContent * 
0x06d71b60, nsEvent * 0x0012f2b0, nsEventStatus * 0x0012f2f4) line 4961 + 39 
bytes
nsButtonBoxFrame::MouseClicked(nsIPresContext * 0x057a27e0, nsGUIEvent * 
0x0012f49c) line 165
nsButtonBoxFrame::HandleEvent(nsButtonBoxFrame * const 0x034ebcfc, 
nsIPresContext * 0x057a27e0, nsGUIEvent * 0x0012f49c, nsEventStatus * 
0x0012f788) line 126
PresShell::HandleEventInternal(nsEvent * 0x0012f49c, nsIView * 0x00000000, 
unsigned int 1, nsEventStatus * 0x0012f788) line 4929 + 38 bytes
PresShell::HandleEventWithTarget(PresShell * const 0x057df5a0, nsEvent * 
0x0012f49c, nsIFrame * 0x034ebcfc, nsIContent * 0x06d71b60, unsigned int 1, 
nsEventStatus * 0x0012f788) line 4895 + 22 bytes
nsEventStateManager::CheckForAndDispatchClick(nsEventStateManager * const 
0x06dfb990, nsIPresContext * 0x057a27e0, nsMouseEvent * 0x0012f894, 
nsEventStatus * 0x0012f788) line 1971 + 61 bytes
nsEventStateManager::PostHandleEvent(nsEventStateManager * const 0x06dfb998, 
nsIPresContext * 0x057a27e0, nsEvent * 0x0012f894, nsIFrame * 0x034ebcfc, 
nsEventStatus * 0x0012f788, nsIView * 0x057a6b40) line 1080 + 28 bytes
PresShell::HandleEventInternal(nsEvent * 0x0012f894, nsIView * 0x057a6b40, 
unsigned int 1, nsEventStatus * 0x0012f788) line 4934 + 43 bytes
PresShell::HandleEvent(PresShell * const 0x057df5a4, nsIView * 0x057a6b40, 
nsGUIEvent * 0x0012f894, nsEventStatus * 0x0012f788, int 1, int & 1) line 4849 + 
25 bytes
nsView::HandleEvent(nsView * const 0x057a6b40, nsGUIEvent * 0x0012f894, unsigned 
int 28, nsEventStatus * 0x0012f788, int 1, int & 1) line 379
nsViewManager2::DispatchEvent(nsViewManager2 * const 0x057a6030, nsGUIEvent * 
0x0012f894, nsEventStatus * 0x0012f788) line 1520
HandleEvent(nsGUIEvent * 0x0012f894) line 68
nsWindow::DispatchEvent(nsWindow * const 0x057c9184, nsGUIEvent * 0x0012f894, 
nsEventStatus & nsEventStatus_eIgnore) line 687 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012f894) line 708
nsWindow::DispatchMouseEvent(unsigned int 301, nsPoint * 0x00000000) line 3948 + 
21 bytes
ChildWindow::DispatchMouseEvent(unsigned int 301, nsPoint * 0x00000000) line 
4158
nsWindow::ProcessMessage(unsigned int 514, unsigned int 0, long 7995971, long * 
0x0012fc48) line 2965 + 24 bytes
nsWindow::WindowProc(HWND__ * 0x01261186, unsigned int 514, unsigned int 0, long 
7995971) line 922 + 27 bytes
USER32! 77e71820()

Comment 5

[gayatrib]

seems to be more of imap problem than a search problem. your thoughts, david?

Comment 6

[David :Bienvenu]

no, it's a search backend problem, almost certainly introduced by taka's recent
checkins to this file. I can look more into it, but this isn't imap code it's
crashing in; it's a simple null pointer problem.

Comment 7

[David :Bienvenu]

taka, I think this is a regression introduced by some recent checkins to
nsMsgSearchAdaptor.cpp (probably 1.27) 
- 	
	ConvertFromUnicode(nsAutoString(convertedValue), nsAutoString(destCharset), &value);
 is leaving value as null, which crashes a bit further down. I'm not sure what
the intention here was - could you help gayatri with this? Thanks!

Comment 8

[Takayuki Tei]

sorry about that, charset must come first.

Comment 9

[Takayuki Tei]

Attachment: correct arguments to call ConvertFromUnicode()

Comment 10

[David :Bienvenu]

can you add some error handling in case this fails? thanks!

Comment 11

[Takayuki Tei]

Attachment: fix with error handling

Comment 12

[gayatrib]

Applied patch and tested. It works. Thanks taka!

Comment 13

[David :Bienvenu]

sr=bienvenu

Comment 14

[gayatrib]

Reassigning to taka.

Comment 15

[Takayuki Tei]

who could be a reviewer?

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

Both david and seth can sr/r.

Comment 17

[(not reading, please use [e-mail] instead)]

you've removed a null check on "value".

it looks like if "value" was null, "oldValue" would be set to null, and 
ConvertFromUnicode() returns NS_OK,

nsCRT::free(oldValue); would crash

can you change it to be CRTFREEIF(oldValue);

someone might change ConvertFromUnicode() to return NS_OK but null for the out
parameter.  (it may do that already, I don't know)

please provide a new patch.

Comment 18

[Takayuki Tei]

Attachment: handle the case above

Comment 19

[Jon Granrose]

ccing self.  I see this in today's build on my win98 system and talkback even
worked...

Comment 20

[(not reading, please use [e-mail] instead)]

sr=sspitzer, check it in.

Comment 21

[Takayuki Tei]

checked in. mark as fixed.

Comment 22

[laurel]

OK using feb8 commercial trunk builds: win98, mac OS 9.0, linux rh6.0