669596 - Style inspector should allow editing of css property values within the UI

Status: RESOLVED WONTFIX

(DevTools :: General, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

From the style inspector it is currently not possible to edit property values. I should be fairly simple to make the values editable by manipulating node.style.

Tracking changes may also be possible but that would be a separate bug.

Comment 1

[Kevin Dangoor]

Edit should be a single click, I think.

Comment 2

[Dave Camp (:dcamp)]

I've put a decent amount of thought into style editing while working on the rule view, I'll look into this for the property view too.

Comment 3

[Dave Camp (:dcamp)]

We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.

Dropping priority in favor of ruleview editing.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Do we know if or how the editing will be done?

Comment 5

[Joe Walker [:jwalker]]

(In reply to Michael Ratcliffe from comment #4)
> Do we know if or how the editing will be done?

The style editor, and/or the rule view?

Comment 6

[Rob Campbell [:rc] (:robcee)]

This bug existed before the Rule View was even a thing. In fact, it kind of led to the Rule View becoming a thing. Given that we now have editing capability in the rule view, I think this bug has become less of a priority.

Do we still want to even do this?

Comment 7

[Rob Campbell [:rc] (:robcee)]

If we do, I think a similar approach to the Rule View's popup text editor is probably the way to go.

Comment 8

[Joe Walker [:jwalker]]

(In reply to Rob Campbell [:rc] (robcee) from comment #6)
> This bug existed before the Rule View was even a thing. In fact, it kind of
> led to the Rule View becoming a thing. Given that we now have editing
> capability in the rule view, I think this bug has become less of a priority.
> 
> Do we still want to even do this?

In my opinion, no.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Note that WebKit doesn't allow editing styles in the Computed Style section either.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The only way I can see rules being editable is if the user clicks a selector css link. In my opinion this should open the style editor (bug 585563).

The problem with this approach is that it is only possible to edit a properties css if it has user styles but I still think it is the best approach.

If we all agree on this then we can resolve this as wontfix in favor of bug 585563.

Comment 11

[Joe Walker [:jwalker]]

Yes - wontfix
I'd like to see the style editor be able to edit styles on elements one day. Until then we have the rule view.

Comment 12

[Rob Campbell [:rc] (:robcee)]

alright! We are agreed. :)

Comment 13

[Rob Campbell [:rc] (:robcee)]

whups.