669682 - The Button "Galerie durchsuchen" in the German locale will be wrapped into a new row

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[u375495]

Attachment: GrafikEinfuegenSumo.png

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

upload an image for the knowledge base


Actual results:

The Button "Galerie durchsuchen" in the German locale will be wrapped into a new row.
I think the text "Galerie durchsuchen" and "Anzeigen" is to long for this line.


Expected results:

The text box should automatically be reduced

Comment 1

[James Socol [:jsocol, :james]]

Could this be localized as "Search" instead of "Search Gallery"? I know of no way to "automatically [reduce]" text like that.

Comment 2

[Kadir Topal [:atopal]]

Well, what should probably happen is that the text box resizes to accommodate a bit more text. 

It's usually not possible to design for the language that takes the most space, but English takes very little space, so for i18n it's a good idea to leave a bit of extra room for other languages or let the design grow with the language.

Comment 3

[James Socol [:jsocol, :james]]

There's really not a lot of space left there. We can make the modal wider, shrink the text box a bit. But, given the context, it really might not be necessary to include "gallery" in the translation (or the English).

Comment 4

[Kadir Topal [:atopal]]

Yeah, for consistency reasons localizers try to stay as close to the original as possible. So we should either change the English text on the button or make the modal dialog wider. Either is fine by me.

Comment 5

[Scoobidiver (away)]

It's also applicable to other verbose languages: French, Italian, Spanish.
The more verbose one is French with "Rechercher dans la galerie" (26 letters).

It's close to bug 617735.

Comment 6

[Joshua Smith [:joshua-s]]

If you want, I can take this and do the same thing that I did in bug 617735.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Joshua Smith [:joshua-s] from comment #6)
> If you want, I can take this and do the same thing that I did in bug 617735.

Yes please :)

Here is a current screenshot:
http://cl.ly/image/12411A0p0u0o

You can see it on https://support.mozilla.org/de/kb/new (for example).

Comment 8

[Joshua Smith [:joshua-s]]

Do you want me to keep the current style, or should I update it to use the other search forms' style.

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Joshua Smith [:joshua-s] from comment #8)
> Do you want me to keep the current style, or should I update it to use the
> other search forms' style.

Make it match the rest of the site. That would be awesome!

Comment 10

[Joshua Smith [:joshua-s]]

In a PR: https://github.com/mozilla/kitsune/pull/1289

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/56805744d161bf0b223e3bd879b00a5611385038

Thanks :joshua-s!

Comment 12

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now!