669718 - Fatal "Assertion failure: (size_t)aWidth <= GetMaxWidth()" in PluginInstanceChild::EnsureCurrentBuffer

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Jesse Ruderman]

Attachment: testcase (requires the test plugin)

###!!! ASSERTION: Cannot create optimized surface: 'Error', file /home/jruderman/mozilla-central/dom/plugins/ipc/PluginInstanceChild.cpp, line 2569

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This fatally asserts on OSX still:

Assertion failure: (size_t)aWidth <= GetMaxWidth(), at /builds/slave/try-m64-d-00000000000000000000/build/src/gfx/2d/MacIOSurface.cpp:307
#01: mozilla::plugins::PluginInstanceChild::EnsureCurrentBuffer() [dom/plugins/ipc/PluginInstanceChild.cpp:2846]
#02: mozilla::plugins::PluginInstanceChild::ShowPluginFrame() [dom/plugins/ipc/PluginInstanceChild.cpp:3209]
#03: mozilla::plugins::PluginInstanceChild::InvalidateRectDelayed() [dom/plugins/ipc/PluginInstanceChild.cpp:3461]
#04: MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) [ipc/chromium/src/base/message_loop.cc:365]
#05: MessageLoop::DoWork() [ipc/chromium/src/base/message_loop.cc:459]
#06: base::MessagePumpCFRunLoopBase::RunWorkSource(void*) [ipc/chromium/src/base/message_pump_mac.mm:278]
#07: CoreFoundation + 0x80681
#08: CoreFoundation + 0x7280d
#09: CoreFoundation + 0x71e3f
#10: CoreFoundation + 0x71858
#11: HIToolbox + 0x2eaef
#12: HIToolbox + 0x2e86a
#13: HIToolbox + 0x2e6ab
#14: AppKit + 0x23f81
#15: AppKit + 0x23730
#16: AppKit + 0x17593
#17: base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) [ipc/chromium/src/base/message_pump_mac.mm:680]
#18: base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) [ipc/chromium/src/base/message_pump_mac.mm:216]
#19: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:520]
#20: XRE_InitChildProcess [xpcom/base/nsAutoPtr.h:195]
#21: content_process_main(int, char**) [ipc/contentproc/plugin-container.cpp:237]

And it appears to leak on Windows:
https://treeherder.mozilla.org/logviewer.html#?job_id=13278688&repo=try

TEST-UNEXPECTED-FAIL | leakcheck | plugin process: 40 bytes leaked (gfxASurface)

But Linux is good anyway! :)

Comment 2

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.