10.39 KB, patch
Stuart Parmenter: review+
|Details | Diff | Splinter Review|
149.71 KB, patch
Mike Pinkerton (not reading bugmail): review+
Simon Fraser: superreview+
|Details | Diff | Splinter Review|
Bug for the new mng decoder in the new imagelib
is there any status on this bug?
I have a prototype MNG decoder in my tree - works fine, but leaks all images. Need to create a custom imgContainer to fix that. I'm planning on getting back to it before 0.9.1.
still on track for landing in the next week or so?
Decoder checked in at modules/libpr0n/decoders/mng. Need some Mac build help to create the project files and do a quick test of the decoder (due to the XP_MAC code that is needed in the image decoders). Looking for review.
looks like this still needs mac help. can we finish this one up in 0.9.2?
Currently, imglib2 contains no support for MNG. Since this is the only animation format available to webmasters who want to avoid the GIF format, it's very important that it be implemented in time for the next release. Delaying this delays progress for the MNG format. Even a little support (like what IE does to PNG) is good enough to increase MNG awareness and help it work its way into image editors and other browsers, and ultimately, become a recommendation.
Actually, I should say none that is available to the browser. According to the webpage, the authors claim that it supports MNG fully.
Tor, planning on landing this on the branch or what?
hwaara: read the 2001-05-21 07:33 comment.
This isn't going to happen for 0.9.2.
CCing mac people in a blatant attempt to attract mac help with project files and testing.
the trunk is dead to me until august at the earliest.
ping me again later this week when I've (hopefully) crawled out from under the focus code's butt and finished helping brendan with the binary object dumping (also mac help).
I just tested if MNG works on Win32, and it does very well! What needs to be done so that it's activated by default?
saari, pink: is there any chance of giving tor the Mac loving he needs? Gerv
i'll have time only after emojo ships.
Nobody on the Mac side has had any time in FOUR MONTHS? Jeez...didn't use to take much longer than that to do an entire Netscape major-version-number release. ;-) Wish I had a Mac for this sort of testing... Greg
I am sorry, I have just been so swamped with school. etc... My tree is full of gunk and it will take a while to sort this all out, I'll see what I can do though. If I create the files, but am not test them, would that be ok? Zach
I have no time whatsoever to work on this. I'm working on getting someone on it though
Nominating for Mozilla 1.0. Strictly speaking, this isn't a standards issue (MNG has not been formally submitted to W3C, IETF, or ISO/IEC), but since MNG is very strongly tied to PNG and its ability to replace GIF in all respects--and since this is a regression, with a patch, awaiting only some final checking on one platform--I think (hope) it qualifies. Surely hot Mac love can't be that hard to come by... :-) Greg
Does this really need to wait for bug#79944 or can this be put into the trunk (after review)? Just wondering--I just can't wait for MNG support to return to Mozilla!
My time is also stunning limited, but I could make Mac project files if someone were able to explain to me what needs to be included. Pointing me at the Windows and or Unix Makefiles will not help much, without some serious hand holding. Best bet is to look for me on IRC (but not till after thanksgiving) (or wait for Pink, who can probably do it in 100th of the time I could)
Looks like the Mac build system is switching over to XML, so I should be able to do the Mac changes myself within a couple weeks.
Don't count on it. The XML is not easily user-editable.
Ok, back to the "need hot mac love" theory.
Comment on attachment 56444 [details] [diff] [review] patch to throw the switch on unix and win32 r=pavlov
*** Bug 114068 has been marked as a duplicate of this bug. ***
CC'ing ccarlen, as he did the mac build conversion to xml and might be able to help.
Created attachment 61262 [details] [diff] [review] new project and build script diffs for Mac Here's a new xml project made completely with a text editor - no IDE required ;-) It builds but I have not tested it. I noticed that the JPEG lib is a static lib, it's sizeable, and it's liked with more than one thing. Couldn't it be a shared lib and then we wouldn't have multiple copies of it in memory?
So what prevents MNG from going into 0.9.7? We have patches to get it building on unix, win32 and mac. The patch for unix and win32 has r= and needs sr= The patch for mac needs r= and sr= Thus, we could celebrate xmas with a mng-enabled Mozilla. That would be very cool indeed.
Good point - bug 114679 filed regarding the jpeg library.
Comment on attachment 56444 [details] [diff] [review] patch to throw the switch on unix and win32 Someone should common those "Browser Content Handler" strings with a const char . email@example.com /be
Comment on attachment 61262 [details] [diff] [review] new project and build script diffs for Mac well, if conrad says it builds, r=pink.
Can someone please give sr= for the Mac patch so this can be checked in to the trunk?
Simon: can you sr= the mac build patch?
Comment on attachment 61262 [details] [diff] [review] new project and build script diffs for Mac sr=sfraser
Checked into trunk.
I think I speak for many in the PNG/MNG community when I say "WOO HOO!" Thanks to everyone, Tim in particular, for getting this (back) in. I hope to test in the next few days (Linux only, though). Greg
Works fine on Windows 98 SE, build 2001121803. Marking VERIFIED.
How about testing the other platforms?
Also works on Linux (Mandrake 8.1), current CVS.
I discovered the mistake about a MNG decoder machine. The red ingredient and the blue ingredient are reversed. I want a developer to correct this bug.
Open a new bug against me, including information that can be used to reproduce the problem such as a test URL/image and the platform you're using.
About: #44 #45 Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.7+) Gecko/20011220 OS:Windows Me(Japanese) Mozilla's BuildID:2001122003 Mozilla's Version:0.9.7+ URL:http://mng.cocky.to/contents/temp/mngbug.htm
If MNG/JNG's MIME-type was 'video/mng' or 'video/jng' on the server machine, I couldn't directly open the MNG/JNG's URLs/Files at Mozilla 0.9.7+(Win32).
We don't listen for unregistered mimetypes, just the image/x-jng and video/x-mng experimental ones. I believe the w3c frowns on jumping the gun on mimetypes.
Hmm... I think my other win32 testers had some rare form of color blindness. :) Ok, I know what's going wrong. Patch coming up...
I'm sorry, I mistook about bug#66976(#45). I made the report of a bug transfer to a following position. bug#66976(#44,#46) -> bug#116378 bug#66976(#47) -> bug#116381
Thank you for replying in the matter of my report(#44,#46,#47).
Reclosing as win32 color problem is now bug 116378.
By http://www.libmng.com/MNGsuite/anke_simi_img.html it seems mng decoder does not work correctly (ICC profiles)
rpolach: that's bug 44866