Closed
Bug 669793
Opened 13 years ago
Closed 13 years ago
IonMonkey: Make value numbering sparse
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: rpearl, Assigned: rpearl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
7.54 KB,
patch
|
adrake
:
review+
|
Details | Diff | Splinter Review |
Follow up to Bug 659729. Currently, we blindly recompute value numbers even when they are known to not change. By tracking more state, we can make the value number pass "sparse" and only recompute value numbers that are known to have changed.
Assignee | ||
Comment 1•13 years ago
|
||
Assertion failure: iter->valueNumber() != 0 at js/src/ion/ValueNumbering.cpp:263 and Assertion failure: ins->valueNumber() != 0 at js/src/ion/ValueNumbering.cpp:273 are manifestations of Bug 678798, a fix of which is much nicer once this patch has been applied.
Attachment #554246 -
Flags: review?(adrake)
Assignee | ||
Comment 2•13 years ago
|
||
Stale patch, sorry.
Attachment #554246 -
Attachment is obsolete: true
Attachment #554248 -
Flags: review?(adrake)
Attachment #554246 -
Flags: review?(adrake)
Updated•13 years ago
|
Attachment #554248 -
Flags: review?(adrake) → review+
Assignee | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/e2abf970b42b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•