Closed
Bug 669800
Opened 13 years ago
Closed 12 years ago
Ensure "heap-unclassified" doesn't regress by adding it to endurance tests
Categories
(Toolkit :: about:memory, defect)
Toolkit
about:memory
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: n.nethercote, Assigned: davehunt)
References
Details
(Whiteboard: [MemShrink:P2])
We're gradually improving the coverage in about:memory (bug 563700). As a result, the "heap-classified" percentage is trending downwards. It would be nice to have some automatic testing that detects if "heap-classified" ever jumps, because that would probably indicate something about the memory reporters got broken.
Reporter | ||
Comment 1•13 years ago
|
||
FWIW, "heap-classified" isn't computed by a single memory reporter, it's computed by about:memory from the "heap-used" reporter and all the KIND_HEAP reporters. So that complicates things a bit.
Comment 2•13 years ago
|
||
Can we report this as a Talos number, for example, obtained from the Tp5 test suite?
Reporter | ||
Updated•13 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P2]
Assignee | ||
Comment 4•13 years ago
|
||
I should be able to add this to the metrics the endurance tests gather. Would it be possible to have a single memory reporter in the same way we now have for explicit? Otherwise, could you point me in the direction of how I can compute this value?
Reporter | ||
Comment 5•13 years ago
|
||
(In reply to comment #4) > I should be able to add this to the metrics the endurance tests gather. > Would it be possible to have a single memory reporter in the same way we now > have for explicit? Yeah, that seems the best approach, because computing "heap-unclassified" is fiddly in exactly the same way that computing "explicit" is. I opened bug 671700 to add that reporter, and renamed this bug to be about using it in endurance tests once it's implemented.
Depends on: 671700
Summary: Ensure "heap-unclassified" doesn't regress → Ensure "heap-unclassified" doesn't regress by adding it to endurance tests
Reporter | ||
Comment 6•12 years ago
|
||
I just WONTFIX'd bug 671700, so this can't be fixed either. I'm not that worried about it, it would be nice to have this but it isn't so important.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•