Closed Bug 669800 Opened 13 years ago Closed 12 years ago

Ensure "heap-unclassified" doesn't regress by adding it to endurance tests

Categories

(Toolkit :: about:memory, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: n.nethercote, Assigned: davehunt)

References

Details

(Whiteboard: [MemShrink:P2])

We're gradually improving the coverage in about:memory (bug 563700).  As a result, the "heap-classified" percentage is trending downwards.  It would be nice to have some automatic testing that detects if "heap-classified" ever jumps, because that would probably indicate something about the memory reporters got broken.
FWIW, "heap-classified" isn't computed by a single memory reporter, it's computed by about:memory from the "heap-used" reporter and all the KIND_HEAP reporters.  So that complicates things a bit.
Blocks: 663416
Can we report this as a Talos number, for example, obtained from the Tp5 test suite?
Whiteboard: [MemShrink] → [MemShrink:P2]
Dave, is this something you can look into?
Assignee: nobody → dave.hunt
I should be able to add this to the metrics the endurance tests gather. Would it be possible to have a single memory reporter in the same way we now have for explicit? Otherwise, could you point me in the direction of how I can compute this value?
(In reply to comment #4)
> I should be able to add this to the metrics the endurance tests gather.
> Would it be possible to have a single memory reporter in the same way we now
> have for explicit?

Yeah, that seems the best approach, because computing "heap-unclassified" is fiddly in exactly the same way that computing "explicit" is.

I opened bug 671700 to add that reporter, and renamed this bug to be about using it in endurance tests once it's implemented.
Depends on: 671700
Summary: Ensure "heap-unclassified" doesn't regress → Ensure "heap-unclassified" doesn't regress by adding it to endurance tests
I just WONTFIX'd bug 671700, so this can't be fixed either.  I'm not that worried about it, it would be nice to have this but it isn't so important.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.