Open Bug 669836 Opened 8 years ago Updated 8 years ago

Make reftest-analyzer.xhtml validate as XHTML5

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

People

(Reporter: fredw, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
The W3C validator detects the doctype of reftest-analyser.xhtml to be "XHTML 1.0 Transitional" and finds 99 Errors. Forcing the doctype to "XHTML 1.1 plus MathML 2.0 plus SVG 1.1" gives 100 Errors. Here is a small patch to make reftest-analyser.xhtml validate as XHTML5. Also adding emacs mode line.
Attachment #544419 - Flags: review?(dbaron)
Comment on attachment 544419 [details] [diff] [review]
Patch

>-        <image x="0" y="0" width="100%" height="100%" id="image1" />
>-        <image x="0" y="0" width="100%" height="100%" id="image2" />
>+        <image x="0" y="0" width="100%" height="100%" id="image1"
>+               xlink:href="" />
>+        <image x="0" y="0" width="100%" height="100%" id="image2"
>+               xlink:href="" />

This change is incorrect, since xlink:href="" implies a recursive link, which we don't want.

r=dbaron on the rest if you skip this change for now.
Attachment #544419 - Flags: review?(dbaron) → review+
Attached patch Patch V2Splinter Review
Attachment #544419 - Attachment is obsolete: true
> This change is incorrect, since xlink:href="" implies a recursive link,
> which we don't want.
> 
> r=dbaron on the rest if you skip this change for now.

Do you prefer to take the patch as it is now or do you have any suggestion to fix this error with missing href?
take it as it is now (but without that change)
Keywords: checkin-needed
Attachment #546195 - Attachment description: Patch V2 → Patch V2 [pushed]
Assignee: fred.wang → nobody
Attachment #546195 - Attachment description: Patch V2 [pushed] → Patch V2
Attachment #546195 - Flags: checkin+
You need to log in before you can comment on or make changes to this bug.