669836 - Make reftest-analyzer.xhtml validate as XHTML5

Status: NEW

(Core :: Layout, defect)

Description

[Frédéric Wang (:fredw)]

Attachment: Patch

The W3C validator detects the doctype of reftest-analyser.xhtml to be "XHTML 1.0 Transitional" and finds 99 Errors. Forcing the doctype to "XHTML 1.1 plus MathML 2.0 plus SVG 1.1" gives 100 Errors. Here is a small patch to make reftest-analyser.xhtml validate as XHTML5. Also adding emacs mode line.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 544419 [details] [diff] [review]
Patch

>-        <image x="0" y="0" width="100%" height="100%" id="image1" />
>-        <image x="0" y="0" width="100%" height="100%" id="image2" />
>+        <image x="0" y="0" width="100%" height="100%" id="image1"
>+               xlink:href="" />
>+        <image x="0" y="0" width="100%" height="100%" id="image2"
>+               xlink:href="" />

This change is incorrect, since xlink:href="" implies a recursive link, which we don't want.

r=dbaron on the rest if you skip this change for now.

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Patch V2

Comment 3

[Frédéric Wang (:fredw)]

> This change is incorrect, since xlink:href="" implies a recursive link,
> which we don't want.
> 
> r=dbaron on the rest if you skip this change for now.

Do you prefer to take the patch as it is now or do you have any suggestion to fix this error with missing href?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

take it as it is now (but without that change)

Comment 5

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4e67f96bbf4a

Comment 6

[Frédéric Wang (:fredw)]

http://hg.mozilla.org/mozilla-central/rev/4e67f96bbf4a