Compile nsDownloadScanner.cpp on mingw

RESOLVED FIXED in mozilla8

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jacek, Assigned: jacek)

Tracking

Trunk
mozilla8
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 544467 [details] [diff] [review]
fix v1.0

nsDownloadScanner.cpp is disabled by Makefile.in on mingw, which causes unresolved symbols when compiling with --with-windows-version=601. It uses SEH exceptions, which need to be replaced by MOZ_SEH_* macros to allow proper mingw compilation. The attached patch fixes the problem.
Attachment #544467 - Flags: review?(jmathies)

Updated

8 years ago
Attachment #544467 - Flags: review?(jmathies) → review+
(Assignee)

Comment 1

8 years ago
Thanks for the review, pushed to m-i:

http://hg.mozilla.org/integration/mozilla-inbound/rev/b3fc635fb392
Whiteboard: [inbound]

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/b3fc635fb392
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.