Closed
Bug 669881
Opened 14 years ago
Closed 14 years ago
Compile nsDownloadScanner.cpp on mingw
Categories
(Toolkit :: Downloads API, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
3.47 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
nsDownloadScanner.cpp is disabled by Makefile.in on mingw, which causes unresolved symbols when compiling with --with-windows-version=601. It uses SEH exceptions, which need to be replaced by MOZ_SEH_* macros to allow proper mingw compilation. The attached patch fixes the problem.
Attachment #544467 -
Flags: review?(jmathies)
Updated•14 years ago
|
Attachment #544467 -
Flags: review?(jmathies) → review+
| Assignee | ||
Comment 1•14 years ago
|
||
Thanks for the review, pushed to m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b3fc635fb392
Whiteboard: [inbound]
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•