669909 - Add "..." to menu items under Manage Account

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[David Tenser [:djst]]

Attachment: Menu items lack "..."

The drop-down menu for the button Manage Accounts under the Options window contains four items that all show you a separate dialog. As such, the menu item captions should end with "..."

This is especially important for an item like "Reset Sync" as the current menu caption makes it look like the account will be reset immediately.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Good catch, David. Easy enough to fix.

Comment 2

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/services/services-central/rev/da8c5f9c9c44

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 544513 [details] [diff] [review]
v1

Bzzt, incorrect ellipsis usage detected.

"Opens a new window" is the wrong heuristic.  "Is an action requiring further info or confirmation" is closer to the truth, though GNOME draws that line a little differently.

Relevant links:

http://msdn.microsoft.com/en-us/library/aa511502.aspx#ellipses
http://developer.apple.com/library/mac/#documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGText/XHIGText.html#//apple_ref/doc/uid/TP30000365-TPXREF126
http://developer.gnome.org/hig-book/stable/menus-design.html.en#menu-item-types

View Quota and My Sync Key shouldn't be changed to add an ellipsis.

Comment 4

[Philipp von Weitershausen [:philikon]]

Uh yeah you're right, Mike. Pushed follow-up as discussed on IRC:

http://hg.mozilla.org/services/services-central/rev/d3dd1a9d6dce

Comment 5

[Mike Connor [:mconnor]]

yay

</petpeeve>

Comment 6

[Tracy Walker [:tracy]]

verified with s-c build of 20110711

Comment 7

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/da8c5f9c9c44
http://hg.mozilla.org/mozilla-central/rev/d3dd1a9d6dce