Closed
Bug 669968
Opened 13 years ago
Closed 13 years ago
remove the requirement to access application.ini in the application directory
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Whiteboard: [android][tegra][mobile_unittests])
Attachments
(1 file)
2.18 KB,
patch
|
bear
:
review+
anodelman
:
feedback+
|
Details | Diff | Splinter Review |
currently we push application.ini (from an extracted .apk file) to /data/data/org.mozilla.f*/ and then copy it to remoteapp.ini. This is a workaround because upon a fresh install there is no application.ini in the directory. So we can copy the extracted application.ini to the talos/remoteapp.ini file and ignore the whole copy and pull from device. That will speed things up a little bit and remove our dependency on accessing /data/data/org.mozilla.f*/
Assignee | ||
Comment 1•13 years ago
|
||
this patch looks like it does the trick.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #544572 -
Flags: review?(bear)
Attachment #544572 -
Flags: feedback?(anodelman)
Assignee | ||
Comment 2•13 years ago
|
||
this is looking good in staging so far, will let bear finish and review.
Comment 3•13 years ago
|
||
Comment on attachment 544572 [details] [diff] [review] don't copy application.ini if remoteapp.ini already exists (1.0) change worked great in tegra staging. working up patch for sut_tools on our side and will file companion bug
Attachment #544572 -
Flags: review?(bear) → review+
Comment 5•13 years ago
|
||
Comment on attachment 544572 [details] [diff] [review] don't copy application.ini if remoteapp.ini already exists (1.0) Looks fine to me too.
Attachment #544572 -
Flags: feedback?(anodelman) → feedback+
Comment 6•13 years ago
|
||
bug 670195 filed to track what is needed on releng side (but this bug does not depend on that change)
Assignee | ||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/build/talos/rev/f2e9e42de965
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•