670034 - Make sure Thunderbird tinderboxes have the latest version of NSIS

Status: VERIFIED FIXED

(Mozilla Messaging Graveyard :: Release Engineering, defect)

Description

[Rain [:rain1] (inactive)]

We currently use NSIS 2.33 on our tinderboxes [1], even though we should be using 2.46. This is probably because of an outdated mozilla-build. We need to update mozilla-build on our tinderboxes ASAP, because this is leading to a broken user experience right now (a dialog box asking if Thunderbird installed correctly, seemingly caused by a somewhat broken manifest embedded by earlier versions of NSIS.)

[1] http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTrunk/1310067063.1310074845.26398.gz&fulltext=1 -- search for makensisu

Comment 1

[Rain [:rain1] (inactive)]

To update mozilla-build I guess we'll need to reinstall mozmill, etc. (Or wait for bug 656736 to land.)

Comment 2

[David :Bienvenu]

This should really be fixed for 6.0 - w/o this fixed, people install TB, and Windows tells you TB may not have been installed correctly doesn't really inspire confidence.

Comment 3

[Mark Banner (:standard8)]

@jhopkins - we'll need this done before we do the first beta of 6.

Comment 4

[Rain [:rain1] (inactive)]

jhopkins set up builds on http://build.mozillamessaging.com/buildbot/try/buildslaves/momo-vm-win2k3-03, but they failed with strange errors. Out of disk space or corrupt filesystem, perhaps?

Comment 5

[Mark Banner (:standard8)]

The push that jhopkins did (build 118) was based on top of some other older pushes to try, which ended up being on top of a changeset from February this year. I certainly wouldn't expect that to build...

Build 119 looks like a failure in what Joshua pushed.

Comment 6

[Rain [:rain1] (inactive)]

Oh, heh, never mind.

Comment 7

[John Hopkins (:jhopkins)]

Here's what I did yesterday:

Installed NSIS 2.46 Unicode on one try server build vm.

D:\tmp> nsis-2.46-Unicode-setup.exe /S /D=d:\mozilla-build\nsis-2.46u

Also checked in a PATH env change to our buildbotcustom repo:

 https://hg.mozilla.org/users/gozer_mozillamessaging.com/buildbotcustom-thunderbird-try/

I'm not sure how my try build push got confused... I must've missed some mercurial step.

Comment 8

[Rain [:rain1] (inactive)]

Fixed try builds are up at https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-10fe6a8d56a5/try-win32/

These builds have the correct manifest, so they work without issues. Looks like the NSIS upgrade worked.

Comment 9

[John Hopkins (:jhopkins)]

All our win32 builders now have the updated NSIS.

Note to self: Unzip http://momo-thumper.sj.mozillamessaging.com/mirror/mozillamessaging.com/nsis-2.46u.zip in /d/

Comment 10

[Rain [:rain1] (inactive)]

I tested with the latest aurora and comm-central builds and verified that they have the correct manifests.