Closed Bug 670095 Opened 8 years ago Closed 8 years ago

gfxWindowsPlatform.cpp fails to compile on mingw

Categories

(Core :: Graphics, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: jacek, Assigned: jacek)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
It uses __in and __out macros, not supported on mingw due to conflicts with GCC-provided headers.
Attachment #544756 - Flags: review?(bas.schouten)
Bas, ping. It's a similar patch to bug 670093, but for other part of code.
Attachment #544756 - Flags: review?(bas.schouten) → review?(jones.chris.g)
Comment on attachment 544756 [details] [diff] [review]
fix v1.0

I'm not 100% sure about the __in/__out stuff, but r=me based on bug 670093.
Attachment #544756 - Flags: review?(jones.chris.g) → review+
Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f44967f832f2
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/f44967f832f2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.