Closed
Bug 670095
Opened 13 years ago
Closed 13 years ago
gfxWindowsPlatform.cpp fails to compile on mingw
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jacek, Assigned: jacek)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
1.11 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
It uses __in and __out macros, not supported on mingw due to conflicts with GCC-provided headers.
Attachment #544756 -
Flags: review?(bas.schouten)
|
Assignee | |
Comment 1•13 years ago
|
||
Bas, ping. It's a similar patch to bug 670093, but for other part of code.
|
|
Assignee | |
Updated•13 years ago
|
Attachment #544756 -
Flags: review?(bas.schouten) → review?(jones.chris.g)
Comment on attachment 544756 [details] [diff] [review] fix v1.0 I'm not 100% sure about the __in/__out stuff, but r=me based on bug 670093.
Attachment #544756 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Thanks for the review, pushed to m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/f44967f832f2
Whiteboard: [inbound]
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f44967f832f2
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•