gfxWindowsPlatform.cpp fails to compile on mingw

RESOLVED FIXED in mozilla10

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla10
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 544756 [details] [diff] [review]
fix v1.0

It uses __in and __out macros, not supported on mingw due to conflicts with GCC-provided headers.
Attachment #544756 - Flags: review?(bas.schouten)
(Assignee)

Comment 1

6 years ago
Bas, ping. It's a similar patch to bug 670093, but for other part of code.
(Assignee)

Updated

6 years ago
Attachment #544756 - Flags: review?(bas.schouten) → review?(jones.chris.g)
Comment on attachment 544756 [details] [diff] [review]
fix v1.0

I'm not 100% sure about the __in/__out stuff, but r=me based on bug 670093.
Attachment #544756 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 3

6 years ago
Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f44967f832f2
Whiteboard: [inbound]

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/f44967f832f2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.