670106 - OGL/GLX does not like image layers that are not xlib surfaces

Status: RESOLVED FIXED

Description

[Florian Hänel [:heeen]]

For the checkerboard pattern I created a gfxImageSurface in layout/ipc/RenderFrameParent.cpp. This is used in an ImageLayerOGL to render the background for fennec.
On EGL, there is no problem, but GLX assumes all ImageLayers are Xlib surfaces, so creating a pixmap fails around here:
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/opengl/ImageLayerOGL.cpp#466

It leads to a crash as soon as you try to open a page.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Created attachment 545493 [details] [diff] [review]
Check the surface type before attempting to create a pixmap

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 545493 [details] [diff] [review]
Check the surface type before attempting to create a pixmap

Review of attachment 545493 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/ImageLayerOGL.cpp
@@ +462,5 @@
>      GLXPixmap pixmap;
>  
>      if (cairoImage->mSurface) {
>          pixmap = sGLXLibrary.CreatePixmap(cairoImage->mSurface);
> +        NS_ASSERTION(pixmap, "Failed to create pixmap!");

Should we have an assertion if we then go on and test for pixmap?

Comment 3

[Matt Woodrow (:mattwoodrow)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9672ad924796

Comment 4

[:Ehsan Akhgari (needinfo please, extremely long backlog)]

http://hg.mozilla.org/mozilla-central/rev/9672ad924796

Matt: please don't mark the bugs which you land on inbound fixed until the patch hits m-c, since it might get backed out before that, and we could potentially miss it because of the bug being marked as fixed.  Thanks!