Closed
Bug 670148
Opened 13 years ago
Closed 13 years ago
Remove some unnecessary xul c interfaces
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Assigned: enndeakin)
Details
Attachments
(3 files)
14.41 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
20.99 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
44.64 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
The interfaces nsIBoxLayout, nsIScrollbarFrame, nsIMenuFrame could be removed and we can just use the non-interface headers instead.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #544811 -
Flags: review?(roc)
Assignee | ||
Comment 3•13 years ago
|
||
Another bug can be used to make nsBoxLayout not inherit from nsISupports as QueryInterface is never called on it.
Attachment #544812 -
Flags: review?(roc)
Comment on attachment 544811 [details] [diff] [review] Remove nsIScrollbarFrame Review of attachment 544811 [details] [diff] [review]: ----------------------------------------------------------------- r+ with those fixed. ::: layout/xul/base/src/nsScrollbarFrame.h @@ +103,2 @@ > virtual void SetScrollbarMediatorContent(nsIContent* aMediator); > virtual nsIScrollbarMediator* GetScrollbarMediator(); These don't need to be virtual anymore. ::: layout/xul/base/src/tree/src/nsTreeBodyFrame.h @@ +177,2 @@ > nsCOMPtr<nsIContent> mVScrollbarContent; > + nsScrollbarFrame* mHScrollbar; Fix indent.
Attachment #544811 -
Flags: review?(roc) → review+
Comment on attachment 544810 [details] [diff] [review] Remove nsIMenuFrame Review of attachment 544810 [details] [diff] [review]: ----------------------------------------------------------------- r+ if you make the nsIMenuFrame methods non-virtual.
Attachment #544810 -
Flags: review?(roc) → review+
Comment on attachment 544812 [details] [diff] [review] Remove nsIBoxLayout Review of attachment 544812 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #544812 -
Flags: review?(roc) → review+
Assignee | ||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/09df029315a7 http://hg.mozilla.org/mozilla-central/rev/b905a7aa518a http://hg.mozilla.org/mozilla-central/rev/8c274d983120
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Comment 8•6 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•