Last Comment Bug 670148 - Remove some unnecessary xul c interfaces
: Remove some unnecessary xul c interfaces
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XP Toolkit/Widgets: XUL (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Neil Deakin
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-08 07:27 PDT by Neil Deakin
Modified: 2011-07-11 07:07 PDT (History)
1 user (show)
enndeakin: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove nsIMenuFrame (14.41 KB, patch)
2011-07-08 07:29 PDT, Neil Deakin
roc: review+
Details | Diff | Splinter Review
Remove nsIScrollbarFrame (20.99 KB, patch)
2011-07-08 07:30 PDT, Neil Deakin
roc: review+
Details | Diff | Splinter Review
Remove nsIBoxLayout (44.64 KB, patch)
2011-07-08 07:31 PDT, Neil Deakin
roc: review+
Details | Diff | Splinter Review

Description Neil Deakin 2011-07-08 07:27:44 PDT
The interfaces nsIBoxLayout, nsIScrollbarFrame, nsIMenuFrame could be removed and we can just use the non-interface headers instead.
Comment 1 Neil Deakin 2011-07-08 07:29:26 PDT
Created attachment 544810 [details] [diff] [review]
Remove nsIMenuFrame
Comment 2 Neil Deakin 2011-07-08 07:30:20 PDT
Created attachment 544811 [details] [diff] [review]
Remove nsIScrollbarFrame
Comment 3 Neil Deakin 2011-07-08 07:31:43 PDT
Created attachment 544812 [details] [diff] [review]
Remove nsIBoxLayout

Another bug can be used to make nsBoxLayout not inherit from nsISupports as QueryInterface is never called on it.
Comment 4 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-07-08 15:40:49 PDT
Comment on attachment 544811 [details] [diff] [review]
Remove nsIScrollbarFrame

Review of attachment 544811 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with those fixed.

::: layout/xul/base/src/nsScrollbarFrame.h
@@ +103,2 @@
>    virtual void SetScrollbarMediatorContent(nsIContent* aMediator);
>    virtual nsIScrollbarMediator* GetScrollbarMediator();

These don't need to be virtual anymore.

::: layout/xul/base/src/tree/src/nsTreeBodyFrame.h
@@ +177,2 @@
>      nsCOMPtr<nsIContent> mVScrollbarContent;
> +    nsScrollbarFrame*   mHScrollbar;

Fix indent.
Comment 5 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-07-08 15:42:27 PDT
Comment on attachment 544810 [details] [diff] [review]
Remove nsIMenuFrame

Review of attachment 544810 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you make the nsIMenuFrame methods non-virtual.
Comment 6 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-07-08 15:44:52 PDT
Comment on attachment 544812 [details] [diff] [review]
Remove nsIBoxLayout

Review of attachment 544812 [details] [diff] [review]:
-----------------------------------------------------------------

Note You need to log in before you can comment on or make changes to this bug.