Remove some unnecessary xul c interfaces

RESOLVED FIXED

Status

()

Core
XP Toolkit/Widgets: XUL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
The interfaces nsIBoxLayout, nsIScrollbarFrame, nsIMenuFrame could be removed and we can just use the non-interface headers instead.
(Assignee)

Comment 1

6 years ago
Created attachment 544810 [details] [diff] [review]
Remove nsIMenuFrame
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #544810 - Flags: review?(roc)
(Assignee)

Comment 2

6 years ago
Created attachment 544811 [details] [diff] [review]
Remove nsIScrollbarFrame
Attachment #544811 - Flags: review?(roc)
(Assignee)

Comment 3

6 years ago
Created attachment 544812 [details] [diff] [review]
Remove nsIBoxLayout

Another bug can be used to make nsBoxLayout not inherit from nsISupports as QueryInterface is never called on it.
Attachment #544812 - Flags: review?(roc)
Comment on attachment 544811 [details] [diff] [review]
Remove nsIScrollbarFrame

Review of attachment 544811 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with those fixed.

::: layout/xul/base/src/nsScrollbarFrame.h
@@ +103,2 @@
>    virtual void SetScrollbarMediatorContent(nsIContent* aMediator);
>    virtual nsIScrollbarMediator* GetScrollbarMediator();

These don't need to be virtual anymore.

::: layout/xul/base/src/tree/src/nsTreeBodyFrame.h
@@ +177,2 @@
>      nsCOMPtr<nsIContent> mVScrollbarContent;
> +    nsScrollbarFrame*   mHScrollbar;

Fix indent.
Attachment #544811 - Flags: review?(roc) → review+
Comment on attachment 544810 [details] [diff] [review]
Remove nsIMenuFrame

Review of attachment 544810 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you make the nsIMenuFrame methods non-virtual.
Attachment #544810 - Flags: review?(roc) → review+
Comment on attachment 544812 [details] [diff] [review]
Remove nsIBoxLayout

Review of attachment 544812 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #544812 - Flags: review?(roc) → review+
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/mozilla-central/rev/09df029315a7
http://hg.mozilla.org/mozilla-central/rev/b905a7aa518a
http://hg.mozilla.org/mozilla-central/rev/8c274d983120
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.