Closed Bug 670167 Opened 14 years ago Closed 14 years ago

Most details page downloads reported lately as "unknown" source in statistics

Categories

(addons.mozilla.org Graveyard :: Statistics, defect, P1)

Product:
addons.mozilla.org Graveyard
Component:
Statistics
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: danielcdawson, Assigned: andy+bugzilla)

Details

Take a look at the stats for an add-on with a significant number of downloads. A really striking example is Greasemonkey ( https://addons.mozilla.org/en-US/statistics/addon/748 ), but I think almost any add-on with available statistics will do. Pull up Download Source and look at what happens around mid-to-late May. It appears that at that time, add-on details page downloads drop sharply while downloads from "unknown" or "null" sources jump to the majority. I think there's a bug somewhere causing them not to be recorded properly. Unless this is intentional? I don't know whether it affects all add-ons, but it appears to be systemic.
https://github.com/jbalogh/zamboni/commit/508d5daae0032cc6b1d443de703c28a0c3c094d7 messed up a ton of download sources. It was only supposed to update contribution sources, which are not checked against a whitelist. Download sources are checked against a whitelist and they were not supposed to change in bug 655857.
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P1
Target Milestone: --- → 6.1.5
Assignee: nobody → amckay
Target Milestone: 6.1.5 → 6.1.6
https://github.com/andymckay/zamboni/commit/feaba3
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Why were all these reverted? It sounds like the other bug was legitimate and now we're going back which will mess up stats. If they weren't working they need to be added to the db.
They're correct now. Download sources weren't supposed to be touched when the contribution sources were changed.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.