670210 - "Basic" snippet service tab not showing snippet content preview every time

Status: RESOLVED FIXED

(Snippets :: Service, defect, P1)

Description

[Laura Forrest]

The Snippet Preview field is blank when you open an existing snippet. There is content within the "Advanced" tab but nothing within the "Snippet Preview" within the basic tab. 

To reproduce: 
Open this existing snippet: 
https://snippets.stage.mozilla.com/admin/homesnippets/snippet/2673/#snippet-basic

Or create a new snippet on staging, save it, close it, then open it again.

Comment 1

[Osmose [:osmose, :mkelly]]

This is caused by two separate issues:

1. The basic form purposefully only is able to edit snippets made using the basic form; older snippets that were not made using the form are not recognized as compatible.

2. Because of bug 670207 new snippets don't have an image embedded, and there is a bug where snippets without images are not recognized.

#2 is a small bug fix, but for #1, do we want the basic form to be able to edit older snippets? The concern here is that older snippets may be malformed or have small customizations that the basic editor might destroy when loading. Do we still want this?

Comment 2

[Osmose [:osmose, :mkelly]]

As per offline discussions, only snippets created by the basic editor will be editable by the basic editor.

A fix for editing text-only snippets has been committed and pushed to stage:

https://github.com/lmorchard/home-snippets-server/commit/b677bbce34f8f2705893b6b2915ca153172696bc

Comment 3

[Laura Forrest]

This is happening again, regardless of the fix of the #2 within comment #1. 

I created a basic snippet, saved it, re-opened, and there was no preview but there was code within the "Advanced" tab. 

One thing to note: I think the first time I saved it it didn't have a image with it. Not sure if that makes a difference. This also seems to be behaving irregularly - 2 of the 4 snippets I created contained this bug, those other two worked fine.

Comment 4

[Osmose [:osmose, :mkelly]]

Laura: Is there a specific snippet you can point me to that is experiencing this issue?

Comment 5

[Laura Forrest]

Grrrrr, this is happening again to this snippet:

Amazon Kindle "Now you can read your Kindle books in Firefox, thanks to the latest HTML5 capabilities. [https://read.amazon.com|Start reading.]" en-US - 1 Week

Comment 6

[Osmose [:osmose, :mkelly]]

The issue appears to be that adding a newline to a snippet causes the basic snippet editor to not recognize the snippet text. Will jump right on it!

Comment 7

[Osmose [:osmose, :mkelly]]

This should be fixed in https://github.com/mozilla/home-snippets-server/commit/5c285cd691a6a87392236d2a8aad09849cd8e1e5