Closed Bug 670230 Opened 9 years ago Closed 9 years ago

[OS/2] missing includes in nsPluginInstanceOwner

Categories

(Core :: Plug-ins, defect, major)

x86
OS/2
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: wuno, Assigned: wuno)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Creation of nsPluginInstanceOwner missed a few includes/defines for OS/2 - breaking the build
Please attach (don't paste in) the build error(s).

When (with which patch on on what date) did the problem start happening?

And what, exactly, is the status of our OS/2 builds?  Is someone doing regular builds?
Blocks: 660721
Attached patch patchSplinter Review
Assignee: nobody → wuno
Status: NEW → ASSIGNED
Attachment #544895 - Flags: review?(daveryeo)
(In reply to comment #1)
> Please attach (don't paste in) the build error(s).
unfortunately I don't have the log anymore. The error was about HPS not declared in this scope
> 
> When (with which patch on on what date) did the problem start happening?
I've added bug660721 (when nsPluginInstanceOwner.cpp was ripped out from code living in other files)
> 
> And what, exactly, is the status of our OS/2 builds?  Is someone doing
> regular builds?
We have currently a shortcoming in official builds until IPC is finally ported. However, to keep our code outside of IPC up-to-date, I'm building (more or less) every day privatly, currently posting from 8.0a1 BuildID=20110707221328
When we're finished with the IPC port we want to come back with official builds.
Attachment #544895 - Flags: review?(daveryeo) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/6c5f3085166c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.