[OS/2] missing includes in nsPluginInstanceOwner

RESOLVED FIXED in mozilla8

Status

()

Core
Plug-ins
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Walter Meinl, Assigned: Walter Meinl)

Tracking

Trunk
mozilla8
x86
OS/2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Creation of nsPluginInstanceOwner missed a few includes/defines for OS/2 - breaking the build
Please attach (don't paste in) the build error(s).

When (with which patch on on what date) did the problem start happening?

And what, exactly, is the status of our OS/2 builds?  Is someone doing regular builds?
(Assignee)

Updated

6 years ago
Blocks: 660721
(Assignee)

Comment 2

6 years ago
Created attachment 544895 [details] [diff] [review]
patch
Assignee: nobody → wuno
Status: NEW → ASSIGNED
Attachment #544895 - Flags: review?(daveryeo)
(Assignee)

Comment 3

6 years ago
(In reply to comment #1)
> Please attach (don't paste in) the build error(s).
unfortunately I don't have the log anymore. The error was about HPS not declared in this scope
> 
> When (with which patch on on what date) did the problem start happening?
I've added bug660721 (when nsPluginInstanceOwner.cpp was ripped out from code living in other files)
> 
> And what, exactly, is the status of our OS/2 builds?  Is someone doing
> regular builds?
We have currently a shortcoming in official builds until IPC is finally ported. However, to keep our code outside of IPC up-to-date, I'm building (more or less) every day privatly, currently posting from 8.0a1 BuildID=20110707221328
When we're finished with the IPC port we want to come back with official builds.

Updated

6 years ago
Attachment #544895 - Flags: review?(daveryeo) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/6c5f3085166c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.