Remove nsIDOMWindowInternal

RESOLVED FIXED in mozilla8

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({dev-doc-complete})

Trunk
mozilla8
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 544894 [details] [diff] [review]
Patch v1

Reviewer appointed by fair dice roll.
Flags: in-testsuite-
Attachment #544894 - Flags: review?(jonas)
Comment on attachment 544894 [details] [diff] [review]
Patch v1

Review of attachment 544894 [details] [diff] [review]:
-----------------------------------------------------------------

Yay!!

Other low hanging fruit: nsIDOMWindowPerformance, nsIDOMStorageIndexedDB, nsIDOMStorageWindow and nsIDOMJSWindow

r=me under the condition that you'll do these in a near future ;-)

Other awesome fruit: nsPIDOMWindow

No "requirement" on this one, but it would be super awesome.
Attachment #544894 - Flags: review?(jonas) → review+
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)
> nsIDOMWindowPerformance
> nsIDOMStorageIndexedDB

These still have a pref; once they're supported unconditionally, I'll be happy to.

> nsIDOMStorageWindow

Will do

> nsIDOMJSWindow

This one has name conflicts, open, openDialog and frames in particular.

> nsPIDOMWindow

Once we can express const methods, constructors, and member variables in IDL? :)
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/b2ba5a0e5dda

And Neil landed

http://hg.mozilla.org/comm-central/rev/bbf03e583fa4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
need to audit extensions for this

Comment 5

6 years ago
and http://hg.mozilla.org/comm-central/rev/93e0048687b7 for Thunderbird

Comment 6

6 years ago
You could rename the parentDOMIntl variables as well:
http://mxr.mozilla.org/mozilla-central/search?string=parentDOMIntl
Could we re-introduce an empty nsIDOMWindowInternal that just inherits from nsIDOMWindow to avoid breaking so many extensions with this change?
This broke many restartless add-ons that were depending on nsIDOMWindowInternal
(In reply to comment #7)
> Could we re-introduce an empty nsIDOMWindowInternal that just inherits from
> nsIDOMWindow to avoid breaking so many extensions with this change?

I'm pretty sure we can. Do we want to? I would suggest filing a bug on it and requesting tracking-firefox8 to get it sorted out.
Depends on: 675075
(In reply to comment #9)
> (In reply to comment #7)
> > Could we re-introduce an empty nsIDOMWindowInternal that just inherits from
> > nsIDOMWindow to avoid breaking so many extensions with this change?
> 
> I'm pretty sure we can. Do we want to? I would suggest filing a bug on it
> and requesting tracking-firefox8 to get it sorted out.

Filed bug 675075
Documentation note:

The stuff previously in nsIDOMWindowInternal is now in nsIDOMWindow instead; there is an empty nsIDOMWindowInternal interface so that add-ons that try to use that won't fail; however, they need to be updated to use nsIDOMWindow instead.

Updated

6 years ago
Depends on: 682639
Docs have been updated already.
Keywords: dev-doc-needed → dev-doc-complete
Depends on: 897176
You need to log in before you can comment on or make changes to this bug.