Last Comment Bug 670235 - Remove nsIDOMWindowInternal
: Remove nsIDOMWindowInternal
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on: 675075 682639 897176
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-08 13:40 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2013-07-24 02:50 PDT (History)
11 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (262.30 KB, patch)
2011-07-08 13:40 PDT, :Ms2ger (⌚ UTC+1/+2)
jonas: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-07-08 13:40:17 PDT
Created attachment 544894 [details] [diff] [review]
Patch v1

Reviewer appointed by fair dice roll.
Comment 1 Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-07-08 16:25:16 PDT
Comment on attachment 544894 [details] [diff] [review]
Patch v1

Review of attachment 544894 [details] [diff] [review]:
-----------------------------------------------------------------

Yay!!

Other low hanging fruit: nsIDOMWindowPerformance, nsIDOMStorageIndexedDB, nsIDOMStorageWindow and nsIDOMJSWindow

r=me under the condition that you'll do these in a near future ;-)

Other awesome fruit: nsPIDOMWindow

No "requirement" on this one, but it would be super awesome.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-07-09 01:49:26 PDT
(In reply to comment #1)
> nsIDOMWindowPerformance
> nsIDOMStorageIndexedDB

These still have a pref; once they're supported unconditionally, I'll be happy to.

> nsIDOMStorageWindow

Will do

> nsIDOMJSWindow

This one has name conflicts, open, openDialog and frames in particular.

> nsPIDOMWindow

Once we can express const methods, constructors, and member variables in IDL? :)
Comment 4 Dão Gottwald [:dao] 2011-07-15 07:29:25 PDT
need to audit extensions for this
Comment 5 David :Bienvenu 2011-07-15 08:50:32 PDT
and http://hg.mozilla.org/comm-central/rev/93e0048687b7 for Thunderbird
Comment 6 Steffen Wilberg 2011-07-16 12:57:04 PDT
You could rename the parentDOMIntl variables as well:
http://mxr.mozilla.org/mozilla-central/search?string=parentDOMIntl
Comment 7 Dave Townsend [:mossop] 2011-07-28 14:33:57 PDT
Could we re-introduce an empty nsIDOMWindowInternal that just inherits from nsIDOMWindow to avoid breaking so many extensions with this change?
Comment 8 Mark Finkle (:mfinkle) (use needinfo?) 2011-07-28 14:35:33 PDT
This broke many restartless add-ons that were depending on nsIDOMWindowInternal
Comment 9 Dão Gottwald [:dao] 2011-07-28 15:43:31 PDT
(In reply to comment #7)
> Could we re-introduce an empty nsIDOMWindowInternal that just inherits from
> nsIDOMWindow to avoid breaking so many extensions with this change?

I'm pretty sure we can. Do we want to? I would suggest filing a bug on it and requesting tracking-firefox8 to get it sorted out.
Comment 10 Dave Townsend [:mossop] 2011-07-28 15:56:47 PDT
(In reply to comment #9)
> (In reply to comment #7)
> > Could we re-introduce an empty nsIDOMWindowInternal that just inherits from
> > nsIDOMWindow to avoid breaking so many extensions with this change?
> 
> I'm pretty sure we can. Do we want to? I would suggest filing a bug on it
> and requesting tracking-firefox8 to get it sorted out.

Filed bug 675075
Comment 11 Eric Shepherd [:sheppy] 2011-09-30 13:11:16 PDT
Documentation note:

The stuff previously in nsIDOMWindowInternal is now in nsIDOMWindow instead; there is an empty nsIDOMWindowInternal interface so that add-ons that try to use that won't fail; however, they need to be updated to use nsIDOMWindow instead.
Comment 12 Eric Shepherd [:sheppy] 2011-10-17 10:59:23 PDT
Docs have been updated already.

Note You need to log in before you can comment on or make changes to this bug.