67024 - Mozilla/Transformiix crashes

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Markus Hübner]

With the latest transformiix binaries and Mozilla 2001012904 it crashes at
http://www.world-direct.com/mozilla/index.asp

Comment 1

[Markus Hübner]

Attachment: the xml file

Comment 2

[Markus Hübner]

Attachment: the relating xsl file

Comment 3

[Markus Hübner]

Attachment: a xsl include file

Comment 4

[Markus Hübner]

Attachment: the javascript file referenced in the xsl file that loads the stylesheet file depending on the browser

Comment 5

[Markus Hübner]

Attachment: the stylesheet file

Comment 6

[Markus Hübner]

Attachment: the new xml file ... removed some lines

Comment 7

[Markus Hübner]

The line that causes the crash is
<xsl:apply-templates select="display_data/featured_articles"/>
in the XSL file.

Comment 8

[Markus Hübner]

Attachment: new index.xsl without any JS calls, hence no CSS import

Comment 9

[Axel Hecht]

This doesn't crash when using the standalone processor, 
BUT:
the result document contains ONLY text nodes, just a #transformiix node plus
alot of text.

This seems completely wrong, don't know offhand why the HTML node isn't created

Axel

Comment 10

[Axel Hecht]

Did a bad when testing on standalone :-(.
It works ok when using the standalone. You can even get rid of the include, btw.

The segfault is in:

#0  0xfc9ed1f4 in XMLDOMUtils::getNodeValue (node=0x8a96f8, target=0xffbec788)
    at /tmp/mozilla/extensions/transformiix/source/xml/XMLDOMUtils.cpp:158
#1  0xfc9e04cc in NodeSet::stringValue (this=0x8b1850, str=@0xffbec788)
    at /tmp/mozilla/extensions/transformiix/source/xpath/NodeSet.cpp:352
#2  0xfca2ac2c in XSLTProcessor::processAction (this=0x756718, node=0x8b0748, 
    xslAction=0x8b1c78, ps=0x6c3510)

The first one, yielding
article.asp?articleNr=2
is ok, but then I crash in the getNodeType of the above statement.
No time to check if the wrapper is created allright then, because the 
nsNodeList returns a non-null node, so I suspect the wrapper code.

Gotta run, OSDEM is taking it's first toll

Axel

Comment 11

[Peter Van der Beken [:peterv]]

Two issues, one is inside the wrappers, the other is XMLDOMUtils::getNodeValue
doesn't return the value of a CDATASectionNode. Taking over.

Comment 12

[Peter Van der Beken [:peterv]]

Attachment: Simplified stylesheet (index.xsl)

Comment 13

[Peter Van der Beken [:peterv]]

Attachment: Simplified testcase (index.xml)

Comment 14

[Peter Van der Beken [:peterv]]

Hmm, fucked up the mimetype of the testcase. Should have been text/xml. BTW
Markus, this is what I call a simplified testcase.

Comment 15

[Peter Van der Beken [:peterv]]

Attachment: Proposed fix.

Comment 16

[Peter Van der Beken [:peterv]]

Fixed. Looking for a review.

Comment 17

[Keith Visco]

I agree with the changes to XMLDOMUtils.cpp, but I don't know anything about the 
wrapper code.

--Keith

Comment 18

[Axel Hecht]

r=me, check it in.

Axel

Comment 19

[Peter Van der Beken [:peterv]]

Checked in.

Comment 20

[Axel Hecht]

verified. nuff said