Backout disabledtext check since it is causing user autocomplete to be very slow

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
User Interface
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Production

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
As discussed in bug 658929, searching for users for the autocomplete feature of Bugzilla is slower when checking for disabledtext = ''. This bug is about backing out the check on BMO until we are able to upgrade to 4.2. With 4.2 this has been reworked to use a boolean (is_enabled) instead and performs much better. We decided that backporting the upstream fix would not be ideal as it requires a database schema change and associated downtime.

Patch coming.

dkl
(Assignee)

Comment 1

7 years ago
To clarify, Bugzilla::User::match will still support excluding of disabled users. This patch will update the JS code in js/field.js to pass include_disabled = 1 to override the default behavior.

dkl
(Assignee)

Comment 2

7 years ago
Created attachment 544908 [details] [diff] [review]
Patch to include disabled users in autocomplete (v1)

Updates JS code for user autocomplete to include disabled users by default.
Attachment #544908 - Flags: review?(glob)
Comment on attachment 544908 [details] [diff] [review]
Patch to include disabled users in autocomplete (v1)

r=glob

nice :)
Attachment #544908 - Flags: review?(glob) → review+
(Assignee)

Comment 4

7 years ago
Should be in the next code update normally on thursdays.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0
modified js/field.js
Committed revision 7790.

dkl
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Depends on: 671803
You need to log in before you can comment on or make changes to this bug.