Closed
Bug 670251
Opened 13 years ago
Closed 13 years ago
Backout disabledtext check since it is causing user autocomplete to be very slow
Categories
(bugzilla.mozilla.org :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dkl, Assigned: dkl)
References
Details
Attachments
(1 file)
512 bytes,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
As discussed in bug 658929, searching for users for the autocomplete feature of Bugzilla is slower when checking for disabledtext = ''. This bug is about backing out the check on BMO until we are able to upgrade to 4.2. With 4.2 this has been reworked to use a boolean (is_enabled) instead and performs much better. We decided that backporting the upstream fix would not be ideal as it requires a database schema change and associated downtime. Patch coming. dkl
Assignee | ||
Comment 1•13 years ago
|
||
To clarify, Bugzilla::User::match will still support excluding of disabled users. This patch will update the JS code in js/field.js to pass include_disabled = 1 to override the default behavior. dkl
Assignee | ||
Comment 2•13 years ago
|
||
Updates JS code for user autocomplete to include disabled users by default.
Attachment #544908 -
Flags: review?(glob)
Comment on attachment 544908 [details] [diff] [review] Patch to include disabled users in autocomplete (v1) r=glob nice :)
Attachment #544908 -
Flags: review?(glob) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Should be in the next code update normally on thursdays. Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0 modified js/field.js Committed revision 7790. dkl
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•