The default bug view has changed. See this FAQ.

Avoid bumping arm target because of neon code

RESOLVED FIXED in mozilla8

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla8
ARM
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We need some binary target correctness: each object file is marked with the target it was built for, and when linking, ld marks the final binary with the greater target it found on the way. With the hacks to allow building unsupported instructions on the target used by the compiler, the resulting objects end up having a bumped target, thus bumping the final binary (libxul) target, which is not expected. Using .object_arch forces the target to be downsized for the given object file, but doesn't affect the final binary target, since other object files are still targeted at whatever target is used by the compiler.
(Assignee)

Comment 1

6 years ago
Created attachment 544967 [details] [diff] [review]
Avoid bumping ARM target because of NEON code in gfx

(Not convinced you are the right reviewer for this)
Attachment #544967 - Flags: review?(doug.turner)

Updated

6 years ago
Attachment #544967 - Flags: review?(doug.turner) → review?(jmuizelaar)
Comment on attachment 544967 [details] [diff] [review]
Avoid bumping ARM target because of NEON code in gfx

Do we need something like this for pixman as well?
Attachment #544967 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 3

6 years ago
pixman already has something like this.
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/b86067d689a9
Assignee: nobody → mh+mozilla
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/b86067d689a9
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.