Closed
Bug 670447
Opened 15 years ago
Closed 12 years ago
signed/unsigned warnings in libssl
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: briansmith, Assigned: briansmith)
Details
Attachments
(1 file)
|
11.45 KB,
patch
|
mmc
:
review+
|
Details | Diff | Splinter Review |
There are several signed/unsigned warnings emitted when building libssl. I would like to eliminate these warnings so that warnings due to new changes are easier to spot.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #545003 -
Flags: review?(wtc)
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → bsmith
|
||
Comment 2•13 years ago
|
||
Comment on attachment 545003 [details] [diff] [review]
Patch to resolve all signed/unsigned warnings in libssl
Review of attachment 545003 [details] [diff] [review]:
-----------------------------------------------------------------
We have an effort in the security engineering team to reduce review latency for our teammates. Even though I'm not an NSS peer, I feel qualified to say that casting to unsigned/signed is OK to remove build warnings.
Nit: I think function style casting is clearer.
|
|
||
Updated•13 years ago
|
Attachment #545003 -
Flags: review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pretty sure the patches have bitrotted to the point where there's no saving them without writing new patches. We should do that in new bugs.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Updated•12 years ago
|
Attachment #545003 -
Flags: review?(wtc)
You need to log in
before you can comment on or make changes to this bug.
Description
•