670626 - IonMonkey: Replace LSRA vregs with operator-overloady class

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Drake [:adrake]]

It would clean up LSRA code quite a bit if the virtual register map could be indexed by definition and use instead of just by integer.

Comment 1

[Andrew Drake [:adrake]]

Attachment: Patch v0

Well, you asked for more operator overloading, so here you go! I feel a bit dirtier for having written "operator" this many times in a single patch.

It seems to have cleaned up the register allocator a little bit, but it's no miracle. Thoughts?

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 545204 [details] [diff] [review]
Patch v0

Seems to be marginally cleaner, but like you said no miracle. Up to you. Seems slightly better than passing uint32 register IDs around since the key acts like a stricter type.

Comment 3

[Andrew Drake [:adrake]]

That's a good point -- I hadn't considered the stricter typing. That's a nice win, I think.

http://hg.mozilla.org/users/danderson_mozilla.com/ionmonkey/rev/f1ee6077ef96