670670 - New hook for requests.cgi that allows for additional links after attachment descriptions.

Status: RESOLVED FIXED

(Bugzilla :: Extensions, enhancement)

Description

[David Lawrence [:dkl]]

New hook for requests.cgi queue template that allows for extensions to add links such as [diff], [review], etc. after the attachment description in a list of requests. 

Patch coming.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to add after_attachment hook to request/queue.html.tmpl (v1)

Comment 2

[Max Kanat-Alexander]

Comment on attachment 545180 [details] [diff] [review]
Patch to add after_attachment hook to request/queue.html.tmpl (v1)

Review of attachment 545180 [details] [diff] [review]:
-----------------------------------------------------------------

::: template/en/default/request/queue.html.tmpl
@@ +203,5 @@
> +        <td>
> +          [% PROCESS "display_$column" %]
> +          [% IF column == 'attachment' %]
> +            [% Hook.process('after_attachment') %]
> +          [% END %] 

Ah, instead, let's do after_column, and let the hook check the value.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to add after_column hook to request/queue.html.tmpl (v2)

Thanks Max. That is better and still works for our needs. Revised patch attached.

dkl

Comment 4

[Max Kanat-Alexander]

Comment on attachment 547210 [details] [diff] [review]
Patch to add after_column hook to request/queue.html.tmpl (v2)

Review of attachment 547210 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. :-)

Comment 5

[David Lawrence [:dkl]]

Thanks Max.

trunk:
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified template/en/default/request/queue.html.tmpl
Committed revision 7863.

4.0:
Committing to: bzr+ssh://[e-mail]/bugzilla/4.0
modified template/en/default/request/queue.html.tmpl
Committed revision 7619.

dkl