should honor mailnews.nav_crosses_folders preference

VERIFIED FIXED

Status

SeaMonkey
MailNews: Message Display
VERIFIED FIXED
18 years ago
6 years ago

People

(Reporter: Alec Flett, Assigned: Alec Flett)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

18 years ago
in 4.x, we had a preference called mailnews.nav_crosses_folders which had three
states to determine the behavior with cross-folder navigation.

0: "next" goes to the next folder, without prompting
1: "next" goes to the next folder, and prompts (the default)
2: "next" does nothing when there are no unread messages

As a big consumer of the "0" case in 4.x, I wanted this so bad that I decided to
tackle this myself
I have a fix in hand, will attach momentarily
(Assignee)

Comment 1

18 years ago
Created attachment 23843 [details] [diff] [review]
proposed fix
(Assignee)

Comment 2

18 years ago
Created attachment 23844 [details] [diff] [review]
diff -bw to make it obvious what's going on
(Assignee)

Comment 3

18 years ago
reassinging to myself now that I've generated sufficient bugmail
Assignee: sspitzer → alecf
looks good.  minor comments:

1) can you default mailnews.nav_crosses_folders to 1 in mailnews.js?
2) can your helpful comment to the js?

var nextMode = pref.GetIntPref("mailnews.nav_crosses_folders");
// 0: "next" goes to the next folder, without prompting
// 1: "next" goes to the next folder, and prompts (the default)
// 2: "next" does nothing when there are no unread messages

there wasn't any ui in 4.x for this, was there?  (just curious)

Updated

18 years ago
QA Contact: esther → fenella
(Assignee)

Comment 5

18 years ago
will do.. I added the comment as suggested, and this line to mailnews.js:
pref("mailnews.nav_crosses_folders", 1); // prompt user when crossing folders

do you need another patch, or is this sufficient?

no, there was no UI in 4.x...

Status: NEW → ASSIGNED
(Assignee)

Comment 7

18 years ago
coolness! fix is in.

Comment 8

18 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 9

18 years ago
Developer, please advise how to re-test this bug. Thanks.
(Assignee)

Comment 10

18 years ago
you can test by editing your prefs to have the preference listed, and checking
each behavior as described.

Comment 11

18 years ago
Linux (2001-02-06-06 mtrunk)
Win32 (2001-02-06-06 mtrunk)
Mac (2001-02-05-12 mtrunk)
I edited the mailnews.js in each of these platforms, and try 
the options: 0, 1, 2
They all behaves as expected.
Status: RESOLVED → VERIFIED

Comment 12

18 years ago
Linux (2001-02-06-06 mtrunk)
Win32 (2001-02-06-06 mtrunk)
Mac (2001-02-05-12 mtrunk)
I edited the mailnews.js in each of these platforms, and try 
the options: 0, 1, 2
They all behaves as expected.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.