67072 - should honor mailnews.nav_crosses_folders preference

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Alec Flett]

in 4.x, we had a preference called mailnews.nav_crosses_folders which had three
states to determine the behavior with cross-folder navigation.

0: "next" goes to the next folder, without prompting
1: "next" goes to the next folder, and prompts (the default)
2: "next" does nothing when there are no unread messages

As a big consumer of the "0" case in 4.x, I wanted this so bad that I decided to
tackle this myself
I have a fix in hand, will attach momentarily

Comment 1

[Alec Flett]

Attachment: proposed fix

Comment 2

[Alec Flett]

Attachment: diff -bw to make it obvious what's going on

Comment 3

[Alec Flett]

reassinging to myself now that I've generated sufficient bugmail

Comment 4

[(not reading, please use [e-mail] instead)]

looks good.  minor comments:

1) can you default mailnews.nav_crosses_folders to 1 in mailnews.js?
2) can your helpful comment to the js?

var nextMode = pref.GetIntPref("mailnews.nav_crosses_folders");
// 0: "next" goes to the next folder, without prompting
// 1: "next" goes to the next folder, and prompts (the default)
// 2: "next" does nothing when there are no unread messages

there wasn't any ui in 4.x for this, was there?  (just curious)

Comment 5

[Alec Flett]

will do.. I added the comment as suggested, and this line to mailnews.js:
pref("mailnews.nav_crosses_folders", 1); // prompt user when crossing folders

do you need another patch, or is this sufficient?

no, there was no UI in 4.x...

Comment 6

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 7

[Alec Flett]

coolness! fix is in.

Comment 8

[timeless]

fixed

Comment 9

[fenella]

Developer, please advise how to re-test this bug. Thanks.

Comment 10

[Alec Flett]

you can test by editing your prefs to have the preference listed, and checking
each behavior as described.

Comment 11

[fenella]

Linux (2001-02-06-06 mtrunk)
Win32 (2001-02-06-06 mtrunk)
Mac (2001-02-05-12 mtrunk)
I edited the mailnews.js in each of these platforms, and try 
the options: 0, 1, 2
They all behaves as expected.

Comment 12

[fenella]

Linux (2001-02-06-06 mtrunk)
Win32 (2001-02-06-06 mtrunk)
Mac (2001-02-05-12 mtrunk)
I edited the mailnews.js in each of these platforms, and try 
the options: 0, 1, 2
They all behaves as expected.