670849 - browser_bug422590.js, browser_bug599325.js and browser_customize.js cause nsIObserverService.removeObserver failure in search.xml

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect)

Description

[Cameron McCormack (:heycam)]

If I make uncaught exceptions in browser-chrome mochitests cause test failures, browser_bug422590.js fails as follows:

TEST-START | chrome://mochitests/content/browser/browser/base/content/test/browser_bug422590.js
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug422590.js | got file menu
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug422590.js | file menu initially enabled
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug422590.js | file menu is disabled during toolbar customization
NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug422590.js | [SimpleTest/SimpleTest.js, window.onerror] - An error occurred: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/search/search.xml ::  :: line 91"  data: no] at :0
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug422590.js | file menu is enabled after toolbar customization
...

Comment 1

[Cameron McCormack (:heycam)]

browser_bug599325.js too:

TEST-START | chrome://mochitests/content/browser/browser/base/content/test/browser_bug599325.js
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug599325.js | got addon bar
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug599325.js | addon bar initially hidden
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug599325.js | add-on bar is visible during toolbar customization
NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug599325.js | [SimpleTest/SimpleTest.js, window.onerror] - An error occurred: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/search/search.xml ::  :: line 91"  data: no] at :0
TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_bug599325.js | addon bar is hidden after toolbar customization
TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_bug599325.js | Console message: [JavaScript Error: "uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/search/search.xml ::  :: line 91"  data: no]"]
INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/browser_bug599325.js | finished in 302ms

Comment 3

[:Gavin Sharp [email: [e-mail]]]

IIRC this can be triggered by opening the Customize Toolbar dialog. Some kind of XBL weirdness related to running the destructor but not the constructor, I think.

Comment 4

[Mark Banner (:standard8)]

browser_bug422590.js was removed by bug 1390260, browser_bug599325.js and browser_customize.js look to have been removed during the Australis work.

Hence calling this WFM.