670975 - account portal originated http requests start with //1.1, should be /1.1

Status: VERIFIED FIXED

(Cloud Services :: Server: Account Portal, defect)

Description

[:Atoll]

"DELETE //1.1/username/storage" is being logged in the sync server logs from account portal.  fix it to only use one slash.

Comment 1

[:Atoll]

doesn't happen on GET, though

GET /1.0/username/info/collections

Comment 2

[Toby Elliott [:telliott]]

Attachment: strips the double-slash

Comment 3

[Toby Elliott [:telliott]]

Attachment: now without the README

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 545409 [details] [diff] [review]
now without the README

This is exactly how the client does it, so r=me.

Comment 8

[Toby Elliott [:telliott]]

Fixed in http://hg.mozilla.org/services/account-portal/rev/aeee28555729

Also hotfixed for current account portal at: http://hg.mozilla.org/services/account-portal/file/ccc2ae4d28cf

Comment 9

[James Bonacci [:jbonacci]]

Verified the specific issue by tracking access logs in AP and Sync:

Examples from ap1.reg.mtv1.stage.svc.mozilla.com:
10.250.64.94 - - [12/Jul/2011:13:17:01 -0700] "GET /sync/request_quota HTTP/1.1" 200 1915 "https://stage-account.services.mozilla.com/" "Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20100101 Firefox/5.0" XFF="10.250.3.45" TIME=0.206 
...etc...
10.250.64.94 - - [12/Jul/2011:13:17:58 -0700] "GET /sync/purge HTTP/1.1" 200 1774 "https://stage-account.services.mozilla.com/sync/request_quota" "Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20100101 Firefox/5.0" XFF="10.250.3.45" TIME=0.003 
...etc...
10.250.64.94 - - [12/Jul/2011:13:18:21 -0700] "POST /sync/purge HTTP/1.1" 200 1398 "https://stage-account.services.mozilla.com/sync/purge" "Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20100101 Firefox/5.0" XFF="10.250.3.45" TIME=0.096
...etc...

...etc...
10.250.64.94 - - [12/Jul/2011:13:39:56 -0700] "POST /sync/purge HTTP/1.1" 200 1398 "https://stage-account.services.mozilla.com/sync/purge" "Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0" XFF="10.250.3.45" TIME=0.114
...etc...


Verified same calls from the Sync side
Examples from sync2.web.mtv1.stage.svc.mozilla.com (search on my encrypted UserID):

Quota:
...etc...
10.250.64.94 - wxm53nzhauutthubzbetf37jrnahhsfd [12/Jul/2011:12:33:20 -0700] "GET /1.1/wxm53nzhauutthubzbetf37jrnahhsfd/info/quota HTTP/1.1" 200 19 "-" "Python-urllib/2.6" XFF="10.250.64.1" TIME=0.020 
10.250.64.94 - wxm53nzhauutthubzbetf37jrnahhsfd [12/Jul/2011:13:01:16 -0700] "GET /1.1/wxm53nzhauutthubzbetf37jrnahhsfd/info/quota HTTP/1.1" 200 18 "-" "Python-urllib/2.6" XFF="10.250.64.1" TIME=0.012 
10.250.64.94 - wxm53nzhauutthubzbetf37jrnahhsfd [12/Jul/2011:13:17:01 -0700] "GET /1.1/wxm53nzhauutthubzbetf37jrnahhsfd/info/quota HTTP/1.1" 200 18 "-" "Python-urllib/2.6" XFF="10.250.64.1" TIME=0.017 
...etc...

Clearing Sync data:
...etc...
10.250.64.94 - wxm53nzhauutthubzbetf37jrnahhsfd [12/Jul/2011:13:39:56 -0700] "DELETE /1.1/wxm53nzhauutthubzbetf37jrnahhsfd/storage HTTP/1.1" 200 4 "-" "Python-urllib/2.6" XFF="10.250.64.1" TIME=0.080 
...etc...

Comment 10

[Philipp von Weitershausen [:philikon]]

I think you meant to set it to VERIFIED/FIXED, not UNCONFIRMED :)