670982 - Uploading multi-package installer produced invalid type error

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: XPI that generates the error

The attached XPI is giving me the following error when trying to upload it:

> Your add-on failed validation with 1 error.
>
>    <em:type> doesn't match add-on

This is a multi-package installer that contains an extension and a theme. All types in the install.rdf files appear to be correct.

I get that error when trying to upload the add-on to preview. When the developer tries on prod, he gets some generic error saying that "this doesn't correspond to a module" (it's localized in French).

This is blocking the developer from submitting an update, so it should be fixed quickly.

Comment 1

[Matt Basta [:basta]]

I can't reproduce this locally. I'm going to look at the implementation in Zamboni and see whether something is amiss there.

Comment 2

[Jeff Balogh (:jbalogh)]

Is it an extension or a theme? It's marked as a theme in the db but when we read <em:type>32</em:type> we assume it's an extension.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #2)
> Is it an extension or a theme? It's marked as a theme in the db but when we
> read <em:type>32</em:type> we assume it's an extension.

Yeah, that seems to be problem, then. A multi-package installer can't be uploaded to a theme listing. I'll ask the developer if he's OK with changing the add-on type on the site.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

The developer raises a good point, and that is that other themes do the same and it works. See Silvermel, for example: https://addons.mozilla.org/en-US/firefox/addon/silvermel/. The listing is a theme, and yet the installer is a mult-package XPI, and it was uploaded very recently.

Has anything changed recently that could be blocking this particular add-on?

Comment 5

[Jeff Balogh (:jbalogh)]

silvermel is detected as a theme because it has     <em:internalName>silvermel</em:internalName> in its install.rdf. The code we're talking about is https://github.com/jbalogh/zamboni/blob/master/apps/files/utils.py#L67.

Comment 6

[Gerard Durand]

Thank for your help all. That was the problem. It's probably a new rule because this is the first time I have to put this keyword at that level (there was already one but inside the internal jar file, but you apparently search now in the "external" install.rdf file. Thanks again.

Comment 7

[krupa raj[:krupa]]

closing the bug based on comment 5 and comment 6

checked that uploading/updating multi-package add-ons works fine.