67109 - Drag and drop to and from textfields is broken

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Blake Ross]

Dragging from and dropping into all textfields (gfx and html) is broken for me 
in my latest build.  (It still works in <editor/>s like Composer itself, and 
mail compose).  Assigning this to Joe initially because of his recent editor 
embedding work.

Comment 1

[Blake Ross]

It would be a shame if .8 went out with this...

Comment 2

[Joe Francis]

this is indeed fallout from the embedding work.  i missed the drag stuff when 
shuffling the interfaces.  fix coming soon...

Comment 3

[Joe Francis]

Attachment: bug fix patch

Comment 4

[Joe Francis]

i failed to move the nsIHTMLEditor drag/drop api down into nsIEditor during my 
refactoring.  Patches do that.  kin, smurfer, can you review?

Comment 5

[hirata masakazu]

In 2001013004 for Mac build, drag and drop of html text string ("foo") to any
form texarea within this page starts Mozilla to load http://www.foo.com. The
textareas are being treated as URL box? Weird.

Comment 6

[Joe Francis]

hirata you should file a separate bug on that.

Comment 7

[Blake Ross]

That's the same bug.  Editor isn't catching the drop, so the event bubbles up 
to the page.

Comment 8

[Joe Francis]

ah, of course.  thanks.

Comment 9

[Blake Ross]

this will be a .8 blocker.  kin/smfr, can you r=?

Comment 10

[kinmoz]

Blake, I already reviewed Joe's code last week, the agreement we have is that 
these functions will be moved to nsIEditor *temporarily* to fix the regression 
for 0.8, and that he will add D&D stub functions to nsEditor so we can 
still instantiate/use it.

FYI, I said *temporarily* because I think that D&D and Paste methods really 
shouldn't be part of the nsIEditor, nsIPlaintextEditor, or nsIHTMLEditor 
interfaces since they are App level features.

Comment 11

[Asa Dotzler [:asa]]

so this is just awaiting sr?  We wrap up 0.8 rsn so if this is going to make it
in it needs to happen in the next couple of days.

Comment 12

[kinmoz]

sr=kin

Comment 13

[anthonyd]

r=anthonyd

Comment 14

[rubydoo123]

removing awaiting review

Comment 15

[anthonyd]

landed joe's fix. oooooooooooooooooooh boy

anthonyd

Comment 16

[kinmoz]

I'm reopening this bug. Joe's attatched patch was checked in, but without the
nsEditor D&D stubs we need to keep nsEditor useable.

Comment 17

[kinmoz]

Nevermind, I'll open a new bug regarding the stubs. Remarking FIXED.

Comment 18

[kinmoz]

I've opened bug #67985 to track the fact that we can no longer instantiate
nsEditor by itself. See bug #67985 for a complete list of methods that are
defined in nsIEditor but not implemented in nsEditor.

Comment 19

[Kathleen :Brade]

verifying with optimized linux mozilla build from 8am today.