Closed Bug 67111 Opened 24 years ago Closed 18 years ago

JS_GetImplementationVersion() date string needs to be updated

Categories

(Core :: JavaScript Engine, defect)

1.8 Branch
x86
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.8beta5

People

(Reporter: pschwartau, Assigned: bc)

References

Details

(Keywords: verified1.8.0.4, verified1.8.1)

Attachments

(3 files, 2 obsolete files)

As jband pointed out a while back, this date string has to be updated
to reflect JS pre-release 2. I have searched in LXR for the string and 
have only found it in one place, in jsapi.c :  


JS_PUBLIC_API(const char *)
JS_GetImplementationVersion(void)
{
  return "JavaScript-C 1.5 pre-release 1 1999 10 31";
}
Isn't it kind of late to be changing it to "2000-08-10" ?
Otherwise, fine with me.
You're right, I should have done it when you first pointed it out! 

But better late than never. Contributors have noticed it, so I'm 
going to re-release the JS_150_RC2 tarball with the updated string - 
Marking 0.8.1, can be checked in today.
Target Milestone: --- → mozilla0.8.1
Since JS pre-release 3 has just been published, I have updated 
JS_GetImplementationVersion() to reflect the new date:


         "JavaScript-C 1.5 pre-release 3 2001-03-07"


Fix checked into trunk, and into JS_150_RC3 branch.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified with latest build of JS shell - 
Status: RESOLVED → VERIFIED
Reopening bug for the RC3a release of JS1.5

Today I tagged mozilla/js/src with this tag: JS_150_RC3a
I'm releasing a tarball for this source today. 

I must update JS_GetImplementationVersion() to today's date -
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Diff of change in JS_GetImplementationVerion() function:


===================================================================
RCS file: /cvsroot/mozilla/js/src/jsapi.c,v
retrieving revision 3.99
diff -r3.99 jsapi.c
1013c1013
<     return "JavaScript-C 1.5 pre-release 3 2001-03-07";
---
>     return "JavaScript-C 1.5 pre-release 3a 2001-05-11";
rs=jband
Fix checked in -
Status: REOPENED → RESOLVED
Closed: 24 years ago23 years ago
Resolution: --- → FIXED
Marking Verified - 
Status: RESOLVED → VERIFIED
Reopening bug for the RC4 release of JS1.5

On 2002-01-01 I tagged mozilla/js/src with this tag: JS_150_RC4.
This, by the way, is an alias for the MOZILLA_0_9_7_RELEASE tag.

Locally, I updated JS_GetImplementationVersion() in jsapi.c to this
date before I made the tarball. This must now be done in the tip.
Looking for sr= and r= for this:


Index: jsapi.c
===================================================================
RCS file: /cvsroot/mozilla/js/src/jsapi.c,v
retrieving revision 3.120
diff -r3.120 jsapi.c
1012c1012
<     return "JavaScript-C 1.5 pre-release 3a 2001-05-11";
---
>     return "JavaScript-C 1.5 pre-release 4 2002-01-01";
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Change checked in -
Status: REOPENED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
Reopening bug for the RC4a release of JS1.5

On 2002-03-21 I tagged mozilla/js/src with the tag JS_150_RC4a.
Locally, I updated JS_GetImplementationVersion() in jsapi.c to this
date before I made the tarball. This must now be done in the tip:


Index: jsapi.c
===================================================================
RCS file: /cvsroot/mozilla/js/src/jsapi.c,v
retrieving revision 3.127
diff -r3.127 jsapi.c
1022c1022
<     return "JavaScript-C 1.5 pre-release 4 2002-01-01";
---
>     return "JavaScript-C 1.5 pre-release 4a 2002-03-21";
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fixed -
Status: REOPENED → RESOLVED
Closed: 23 years ago22 years ago
Resolution: --- → FIXED
Verified -
Status: RESOLVED → VERIFIED
Reopening bug for the RC5 release of JS1.5.

Today I am tagging mozilla/js/src with the tag JS_150_RC5, and
updating JS_GetImplementationVersion() in jsapi.c to this date:


Index: jsapi.c
===================================================================
RCS file: /cvsroot/mozilla/js/src/jsapi.c,v
retrieving revision 3.132
diff -r3.132 jsapi.c
1025c1025
<     return "JavaScript-C 1.5 pre-release 4a 2002-03-21";
---
>     return "JavaScript-C 1.5 pre-release 5 2003-01-10";
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Fixed -
Status: REOPENED → RESOLVED
Closed: 22 years ago22 years ago
Resolution: --- → FIXED
Verified -
Status: RESOLVED → VERIFIED
Reopening bug for the RC5a release of JS1.5.

Today I am tagging mozilla/js/src with the tag JS_150_RC5a, and
updating JS_GetImplementationVersion() in jsapi.c to this date:


Index: jsapi.c
===================================================================
RCS file: /cvsroot/mozilla/js/src/jsapi.c,v
retrieving revision 3.142
diff -r3.142 jsapi.c
1025c1025
<     return "JavaScript-C 1.5 pre-release 5 2003-01-10";
---
>     return "JavaScript-C 1.5 pre-release 5a 2003-05-29";
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Fixed -
Status: REOPENED → RESOLVED
Closed: 22 years ago21 years ago
Resolution: --- → FIXED
Verified -
Status: RESOLVED → VERIFIED
Reopening bug for the RC6 release of JS1.5.

Today I am tagging mozilla/js/src/ with the tag JS_150_RC6, and
updating JS_GetImplementationVersion() in jsapi.c to this date:


Index: jsapi.c
===================================================================
RCS file: /cvsroot/mozilla/js/src/jsapi.c,v
retrieving revision 3.159
diff -r3.159 jsapi.c
1036c1036
<     return "JavaScript-C 1.5 pre-release 5a 2003-05-29";
---
>     return "JavaScript-C 1.5 pre-release 6 2004-01-27";
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Fixed -
Status: REOPENED → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → FIXED
Verified -
Status: RESOLVED → VERIFIED
Reopening bug for the RC6a release of JS1.5.

Today I am tagging mozilla/js/src/ with the tag JS_150_RC6a, and
updating JS_GetImplementationVersion() in jsapi.c to today's date:


Index: jsapi.c
===================================================================
RCS file: /cvsroot/mozilla/js/src/jsapi.c,v
retrieving revision 3.172
diff -r3.172 jsapi.c
1059c1059
<     return "JavaScript-C 1.5 pre-release 6 2004-01-27";
---
>     return "JavaScript-C 1.5 pre-release 6a 2004-06-09";



Note: often JS_150 tags are simply created from a tip pull, but
this time, JS_150_RC6a is an alias for the MOZILLA_1_7_BRANCH tag.

Certain subdirectories of mozilla/js/src never get hit by MOZILLA
tags, though, so I tagged them with JS_150_RC6a based on tip pulls:


                mozilla/js/src/config
                mozilla/js/src/liveconnect/config
                mozilla/js/src/perlconnect
                mozilla/js/src/editline


This problem always arises whenever we base a JS_150 tag
on a MOZILLA tag, and is handled in this way -
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Fixed - 

[~/d/JS_TRUNK/mozilla/js/src] cvs ci -m "Updating JS_GetImplementationVersion()
to date of latest JS release (67111)" jsapi.c

Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.173; previous revision: 3.172
done
Status: REOPENED → RESOLVED
Closed: 21 years ago20 years ago
Resolution: --- → FIXED
Blocks: js1.6rc1
Reopening bug for the RC 7 release of JS1.5.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: pschwartau → bob
Status: REOPENED → NEW
QA Contact: pschwartau → general
Target Milestone: mozilla0.8.1 → mozilla1.8beta5
Version: Trunk → 1.8 Branch
Blocks: 309511
Attachment #217064 - Flags: review?(brendan)
Attached patch patch for trunkSplinter Review
Attachment #217065 - Flags: review?(brendan)
Attached patch patch for trunk (obsolete) — Splinter Review
Attachment #217066 - Flags: review?(brendan)
First patch looks like the big patch for bug 309169 -- is that the right patch?

Other patches should say 1.6, not 1.8, in the impl version string -- this is not a Gecko rv: value, it's the JS1.6 version number.

/be
(In reply to comment #32)
> First patch looks like the big patch for bug 309169 -- is that the right patch?
> 

crap, I should have diffed against a clean tree. no, it should just include the following 

 JS_PUBLIC_API(const char *)
 JS_GetImplementationVersion(void)
 {
-    return "JavaScript-C 1.5 pre-release 6a 2004-06-09";
+    return "JavaScript-C 1.6 pre-release 1 2006-04-04";
 }

which if it is ok, will get checked in with the rollup patch in bug 309169.
 
> Other patches should say 1.6, not 1.8, in the impl version string -- this is
> not a Gecko rv: value, it's the JS1.6 version number.

I was bumping the js version for the gecko 1.8 branch to js 1.7 and the js version on the trunk to js 1.8 in anticipation of the march to js 2.0. I can keep them all at js 1.6, but they are kind of different already and I wanted to distinguish them.
(In reply to comment #33)
> which if it is ok, will get checked in with the rollup patch in bug 309169.

rs=me on that too!

> I was bumping the js version for the gecko 1.8 branch to js 1.7 and the js
> version on the trunk to js 1.8 in anticipation of the march to js 2.0.

Bump both to 1.8 to JS1.6, to match the 1.8.0 branch at some point.  The trunk should be at JS1.7 now, and nothing should go to JS1.8 till there's a difference that isn't going to be in JS1.7.

/be
Attachment #217064 - Attachment is obsolete: true
Attachment #217064 - Flags: review?(brendan)
Attachment #217066 - Attachment is obsolete: true
Attachment #217066 - Flags: review?(brendan)
Comment on attachment 217065 [details] [diff] [review]
patch for trunk

Ok, this should do it.
Attachment #217065 - Attachment description: patch for MOZILLA_1_8_BRANCH → patch for MOZILLA_1_8_0_BRANCH, MOZILLA_1_8_BRANCH and trunk
Attachment #217065 - Flags: approval1.8.0.3?
Attachment #217065 - Flags: approval-branch-1.8.1?
Comment on attachment 217065 [details] [diff] [review]
patch for trunk

sorry, i misunderstood and its getting late.
Attachment #217065 - Attachment description: patch for MOZILLA_1_8_0_BRANCH, MOZILLA_1_8_BRANCH and trunk → patch for trunk
Attachment #217065 - Flags: approval1.8.0.3?
Attachment #217065 - Flags: approval-branch-1.8.1?
Attached patch patch for 1.8Splinter Review
bump js version to 1.6 on 1.8.*
Attachment #217100 - Flags: review?(brendan)
Attachment #217100 - Flags: approval1.8.0.3?
Attachment #217100 - Flags: approval-branch-1.8.1?(brendan)
Attachment #217065 - Flags: review?(brendan) → review+
Attachment #217100 - Flags: review?(brendan)
Attachment #217100 - Flags: review+
Attachment #217100 - Flags: approval-branch-1.8.1?(brendan)
Attachment #217100 - Flags: approval-branch-1.8.1+
trunk: checked in attachment 217065 [details] [diff] [review]
Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.253; previous revision: 3.252

1.8: checked in attachment 217100 [details] [diff] [review]
Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.214.2.17; previous revision: 3.214.2.16

SPIDERMONKEY_1_6_0_BRANCH already has the update.



Status: NEW → RESOLVED
Closed: 20 years ago18 years ago
Resolution: --- → FIXED
fixed1.8.1 per comment 38
Keywords: fixed1.8.1
Comment on attachment 217100 [details] [diff] [review]
patch for 1.8

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #217100 - Flags: approval1.8.0.3? → approval1.8.0.3+
Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.214.2.11.2.4; previous revision: 3.214.2.11.2.3
done
Keywords: fixed1.8.0.3
while not technically kosher, by code inspection verified 1.8.0, 1.8, 1.9 branches.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: